Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Remove linting exceptions in nodes-base #4794

Merged
merged 26 commits into from
Dec 2, 2022
Merged

refactor(core): Remove linting exceptions in nodes-base #4794

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9469803
:zap: enabled array-type
michael-radency Dec 2, 2022
3721797
:zap: await-thenable on
michael-radency Dec 2, 2022
b5442ce
:zap: ban-types on
michael-radency Dec 2, 2022
ae44257
Merge branch 'master' of https://github.com/n8n-io/n8n into n8n-5626-…
michael-radency Dec 2, 2022
a16a5df
:zap: default-param-last on
michael-radency Dec 2, 2022
7914d11
:zap: dot-notation on
michael-radency Dec 2, 2022
def2631
:zap: member-delimiter-style on
michael-radency Dec 2, 2022
98c60bf
Merge branch 'master' of https://github.com/n8n-io/n8n into n8n-5626-…
michael-radency Dec 2, 2022
f157794
:zap: no-duplicate-imports on
michael-radency Dec 2, 2022
24987a4
:zap: no-empty-interface on
michael-radency Dec 2, 2022
d1e0a77
:zap: no-floating-promises on
michael-radency Dec 2, 2022
f3ca250
:zap: no-for-in-array on
michael-radency Dec 2, 2022
9df0d34
:zap: no-invalid-void-type on
michael-radency Dec 2, 2022
961192c
:zap: no-loop-func on
michael-radency Dec 2, 2022
fe6ebb2
:zap: no-shadow on
michael-radency Dec 2, 2022
c0f1a8c
Merge branch 'master' of https://github.com/n8n-io/n8n into n8n-5626-…
michael-radency Dec 2, 2022
06f1e62
:zap: ban-ts-comment re enabled
michael-radency Dec 2, 2022
596be3c
:zap: @typescript-eslint/lines-between-class-members on
netroy Dec 2, 2022
3d098c5
address my own comment
netroy Dec 2, 2022
ce2e43d
@typescript-eslint/return-await on
netroy Dec 2, 2022
55504ba
@typescript-eslint/promise-function-async on
netroy Dec 2, 2022
a1f6d5b
@typescript-eslint/no-unnecessary-boolean-literal-compare on
netroy Dec 2, 2022
f7d4244
@typescript-eslint/no-unnecessary-type-assertion on
netroy Dec 2, 2022
f571b33
prefer-const on
netroy Dec 2, 2022
059bdd5
@typescript-eslint/prefer-optional-chain on
netroy Dec 2, 2022
2493d47
Merge remote-tracking branch 'origin/master' into n8n-5626-remove-lin…
netroy Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/nodes-base/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module.exports = {
'prefer-spread': 'off',
'import/no-extraneous-dependencies': 'off',

'@typescript-eslint/array-type': 'off',
// '@typescript-eslint/array-type': 'off',
'@typescript-eslint/await-thenable': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/default-param-last': 'off',
Expand Down Expand Up @@ -55,7 +55,8 @@ module.exports = {
'@typescript-eslint/restrict-template-expressions': 'off',
'@typescript-eslint/return-await': 'off',
'@typescript-eslint/unbound-method': 'off',
'@typescript-eslint/ban-ts-comment': ['warn', { 'ts-ignore': true }],
// '@typescript-eslint/ban-ts-comment': ['warn', { 'ts-ignore': true }],
'@typescript-eslint/ban-ts-comment': 'off',
netroy marked this conversation as resolved.
Show resolved Hide resolved
},

overrides: [
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Ftp/Ftp.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ async function callRecursiveList(

do {
// tslint:disable-next-line: array-type
const returnData: sftpClient.FileInfo[] | (string | ftpClient.ListingElement)[] =
const returnData: sftpClient.FileInfo[] | Array<string | ftpClient.ListingElement> =
await client.list(pathArray[index]);

// @ts-ignore
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/SeaTable/GenericFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ const uniquePredicate = (current: string, index: number, all: string[]) =>
all.indexOf(current) === index;
const nonInternalPredicate = (name: string) => !Object.keys(schema.internalNames).includes(name);
const namePredicate = (name: string) => (named: IName) => named.name === name;
export const nameOfPredicate = (names: ReadonlyArray<IName>) => (name: string) =>
export const nameOfPredicate = (names: readonly IName[]) => (name: string) =>
names.find(namePredicate(name));

export function columnNamesToArray(columnNames: string): string[] {
Expand Down
6 changes: 3 additions & 3 deletions packages/nodes-base/nodes/SeaTable/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ type TInheritColumnKey =
type TColumnValue = undefined | boolean | number | string | string[] | null;
type TColumnKey = TInheritColumnKey | string;

export type TDtableMetadataTables = ReadonlyArray<IDtableMetadataTable>;
export type TDtableMetadataColumns = ReadonlyArray<IDtableMetadataColumn>;
export type TDtableViewColumns = ReadonlyArray<TDtableViewColumn>;
export type TDtableMetadataTables = readonly IDtableMetadataTable[];
export type TDtableMetadataColumns = readonly IDtableMetadataColumn[];
export type TDtableViewColumns = readonly TDtableViewColumn[];

// ----------------------------------
// api
Expand Down