Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add run name and start url for e2e tests and docker nighly command (no-changelog) #4800

Merged
merged 7 commits into from
Dec 2, 2022
Merged

ci: Add run name and start url for e2e tests and docker nighly command (no-changelog) #4800

merged 7 commits into from
Dec 2, 2022

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Dec 2, 2022

No description provided.

@mutdmour mutdmour requested a review from netroy December 2, 2022 16:06
@mutdmour mutdmour changed the title ci: add run name and start url for e2e tests and docker nighly command ci: Add run name and start url for e2e tests and docker nighly command Dec 2, 2022
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 2, 2022
netroy
netroy reviewed Dec 2, 2022
View reviewed changes
.github/workflows/e2e-tests.yml

- name: Call Success URL - optionally
run: |
[[ "${{github.event.inputs.success-url}}" != "" ]] && curl -v ${{github.event.inputs.success-url}} || echo ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is GET because that's what the other workflow does ? it might make sense to eventually make this POST and add branch name and user name in the payload.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya you are right.. post makes more sense.. but would break two workflows, one of which Jan owns.. that's why I did not bother at this point

@netroy netroy changed the title ci: Add run name and start url for e2e tests and docker nighly command ci: Add run name and start url for e2e tests and docker nighly command (no-changelog) Dec 2, 2022
@netroy netroy merged commit 8101c05 into master Dec 2, 2022
@netroy netroy deleted the e2e-workflow branch December 2, 2022 18:56
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 2, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 5, 2022
@MiloradFilipovic
Merge branch 'master' into feature/undo-redo
3e6477a 
* master:
  fix(core): Fix linter error (#4808)
  refactor(core): Remove linting exceptions in nodes-base (#4794)
  ci: Add run name and start url for e2e tests and docker nighly command (no-changelog) (#4800)
@janober
Copy link
Member

janober commented Dec 7, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @netroy