Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Skip license activation when instance was already activated #6064

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

csuermann
Copy link
Contributor

No description provided.

@csuermann csuermann requested a review from netroy April 21, 2023 15:24
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 10.81% and project coverage change: -0.01 ⚠️

Comparison is base (54f99a7) 18.64% compared to head (ae49b47) 18.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6064      +/-   ##
==========================================
- Coverage   18.64%   18.63%   -0.01%     
==========================================
  Files        2583     2585       +2     
  Lines      116471   116487      +16     
  Branches    18179    18182       +3     
==========================================
- Hits        21714    21711       -3     
- Misses      94119    94138      +19     
  Partials      638      638              
Impacted Files Coverage Δ
packages/cli/src/License.ts 57.95% <0.00%> (-4.25%) ⬇️
packages/cli/src/commands/license/info.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/start.ts 0.00% <0.00%> (ø)
packages/cli/src/config/schema.ts 37.50% <ø> (ø)
packages/cli/src/license/license.controller.ts 81.48% <100.00%> (+0.34%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit eaf7090 into master Apr 24, 2023
@netroy netroy deleted the skip-activation branch April 24, 2023 09:46
MiloradFilipovic added a commit that referenced this pull request Apr 24, 2023
* master:
  refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041)
  SSO/SAML : add Base URL to redirects in acsHandler (#5923)
  refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060)
  fix(core): Skip license activation when instance was already activated (#6064)
  refactor(core): Setup decorator based RBAC (no-changelog) (#5787)

# Conflicts:
#	packages/editor-ui/src/mixins/restApi.ts
MiloradFilipovic added a commit that referenced this pull request Apr 24, 2023
* master:
  refactor(editor): Delete leftover restApi mixin file (no-changelog) (#6074)
  docs: Remove version notice from overhauled nodes (no-changelog) (#6071)
  refactor(editor): Combine type imports in `editor-ui` (no-changelog) (#6072)
  refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041)
  SSO/SAML : add Base URL to redirects in acsHandler (#5923)
  refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060)
  fix(core): Skip license activation when instance was already activated (#6064)
  refactor(core): Setup decorator based RBAC (no-changelog) (#5787)
  test: Add run linking tests (#6061)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInputWrapper.vue
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants