Support newer Debian releases #70
Conversation
There was a problem hiding this comment.
I think we want to keep contrib support, but would also be worth @sagepe reviewing this.
There was a problem hiding this comment.
From a FMS/TWFY/mapit point of view, I don't think any of them use contrib/non-free, so happy to have them go and get buster etc support.
One thing to consider in the "Support newer Debian" commit is update_mysociety_apt_sources - this is stretch on stretch/X-A ubuntu, jessie on jessie, wheezy on anything else. I think the only thing TWFY uses is php7-xapian which is only in stretch, perhaps this should be changed to just only use stretch and drop the jessie/wheezy parts? @sagepe can probably answer better on that.
|
Looking through this, I'm inclined to make a set of changes - I've already got these drafted locally, I'll tidy them up and add another commit shortly for review, but essentially these will:
Feel free to shout now if there's anything hugely controversial there, or wait until the commit is finalised - I'm intending to get this tested locally today, but wanted to outline my thoughts in case it gets delayed. |
sagepe
force-pushed
the
support-newer-debian
branch
from
fb49bd3 to
fa7cea6
Compare
|
So, if everyone is happy with the final form of this, let me know - I'm happy to just squash this all together into a single commit. |
Can't approve my own PR but yes this as a squashed commit looks fine to me. |
sagepe
force-pushed
the
support-newer-debian
branch
from
fa7cea6 to
886da59
Compare
This removes support for everything before Xenial and Stretch and adds support up to Focal and Buster. It should be noted that the mySociety repository only has formal support for Debian and not Ubuntu, so each Ubuntu release is currently mapped to the closest available Debian version, which may work for at least some packages. This also refactors the repository sections slightly, templating them based on the specific versions in question to reduce duplication.
sagepe
force-pushed
the
support-newer-debian
branch
from
886da59 to
e6eb814
Compare
We've now added explicit support for Xenial, Bionic and Focal to our repository, so this reflects that.
|
I've added a further commit that creates Ubuntu-specific versions of the mySociety repo now that we're supporting those, too. |
We're looking at the possibility of dropping Ruby 2.3 support in Alaveteli [1] but need to support a newer version of Debian which has a later so this allows us to build Buster images without getting a unsupported distribution and version combination error.
[1] mysociety/alaveteli#5222