[#5226] Add buster support

[gbp]

Relevant issue(s)

Fixes #5226
See https://github.com/mysociety/sysadmin/issues/867
Requires mysociety/commonlib#70

What does this do?

1. Switches the wkhtmltox package
2. Adds vagrant buster box

Why was this needed?

To support the Debian version

Implementation notes

These are commits from commonlib package repo changes

[gbp]

I've run the specs against a Buster Vagrant box - they all pass expect some Xapian index issues which seems to be related to vagrant disk IO, same failures on my Stretch box.

@garethrees is there anything else we need to do here to "support" Buster?

[garethrees]

@garethrees is there anything else we need to do here to "support" Buster?

Looking at #5232, #5000 and #4218, only thing I can think of is adding a changelog entry 👍

[gbp]

Great. Will wait for mysociety/commonlib#70 then we can merge this

[garethrees]

Noting we might need to check Zip download PDF generation still works https://github.com/mysociety/sysadmin/issues/867#issuecomment-766769338.

[gbp]

@garethrees think we need to get this merged. When building a bionic box I'm seeing:

    bionic: Installing packages from repository packages file...
    bionic: E
    bionic: :
    bionic: Unable to locate package wkhtmltopdf-static

[garethrees]

Couple of things need to do before merge:

• Update HTML_TO_PDF_COMMAND https://github.com/mysociety/sysadmin/issues/867#issuecomment-756155743
  • This warrants a changelog entry
  • Will the new default be true for each supported OS, or will people have to change based on latest debian/ubuntu?
• Confirm zip generation still works [#5226] Add buster support #6056 (comment)
• Update commonlib to get mysociety/commonlib@e015b9a
• Rebase on develop

[garethrees]

After rebasing on develop and updating commonlib to get mysociety/commonlib@e015b9a, this currently fails because of #6229.

    default: Bundle complete! 86 Gemfile dependencies, 168 gems now installed.
    default: Bundled gems are installed into `/home/vagrant/bundle/`
    default: Post-install message from gender_detector:
    default: For unicode support you'll need to also install the unicode_utils or activesupport gem
    default: Post-install message from icalendar:
    default: ActiveSupport is required for TimeWithZone support, but not required for general use.
    default: rake aborted!
    default: LoadError: /home/vagrant/bundle/ruby/2.5.0/extensions/x86_64-linux/2.5.0/mini_racer-0.4.0/mini_racer_extension.so: undefined symbol: _ZNSt7__cxx1119basic_ostringstreamIcSt11char_traitsIcESaIcEEC1Ev
    default: /home/vagrant/bundle/ruby/2.5.0/gems/mini_racer-0.4.0/lib/mini_racer.rb:11:in `load'
    default: /home/vagrant/bundle/ruby/2.5.0/gems/mini_racer-0.4.0/lib/mini_racer.rb:11:in `<top (required)>'
    default: /usr/share/rubygems-integration/all/gems/bundler-1.17.3/lib/bundler/runtime.rb:81:in `require'
    default: /usr/share/rubygems-integration/all/gems/bundler-1.17.3/lib/bundler/runtime.rb:81:in `block (2 levels) in require'
    default: /usr/share/rubygems-integration/all/gems/bundler-1.17.3/lib/bundler/runtime.rb:76:in `each'
    default: /usr/share/rubygems-integration/all/gems/bundler-1.17.3/lib/bundler/runtime.rb:76:in `block in require'
    default: /usr/share/rubygems-integration/all/gems/bundler-1.17.3/lib/bundler/runtime.rb:65:in `each'
    default: /usr/share/rubygems-integration/all/gems/bundler-1.17.3/lib/bundler/runtime.rb:65:in `require'
    default: /usr/share/rubygems-integration/all/gems/bundler-1.17.3/lib/bundler.rb:114:in `require'
    default: /home/vagrant/alaveteli/config/application.rb:21:in `<top (required)>'
    default: /home/vagrant/alaveteli/rakefile:4:in `require_relative'
    default: /home/vagrant/alaveteli/rakefile:4:in `<top (required)>'
    default: /home/vagrant/bundle/ruby/2.5.0/gems/rake-13.0.3/exe/rake:27:in `<top (required)>'
    default: (See full trace by running task with --trace)
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

[garethrees]

This commit should also change HTML_TO_PDF_COMMAND in config/general.yml-example