Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error updating APT sources #73

Closed
gbp opened this issue May 4, 2021 · 3 comments · Fixed by #74
Closed

Error updating APT sources #73

gbp opened this issue May 4, 2021 · 3 comments · Fixed by #74

Comments

@gbp
Copy link
Member

gbp commented May 4, 2021

When building a fresh Vagrant box I am seeing:

Updating APT sources...
/home/vagrant/alaveteli/commonlib/bin/install-site.sh: 167: [: false: unexpected operator

commonlib/bin/install-site.sh

Line 167 in 02fa755

if [ "$BACKPORTS" == "true" ]

@dracos
Copy link
Member

dracos commented May 4, 2021

Which OS is it running on?

@dracos
Copy link
Member

dracos commented May 4, 2021

Anyway, doesn't matter, that's not valid sh with two equals.

@dracos
Copy link
Member

dracos commented May 4, 2021

The other ifs in #70 were okay, but this one should probably be if [ x"$BACKPORTS" = x"true" ] to match.

@gbp gbp mentioned this issue May 5, 2021
Merged
@gbp gbp changed the title Error updateing APT sources Error updating APT sources May 5, 2021
@gbp gbp closed this as completed in #74 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix conditional mysociety/commonlib
2 participants
@gbp @dracos