Remove unicode gem #5907
Merged
Remove unicode gem #5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
remove-unicode-gbp
branch
2 times, most recently
from
e7fef77 to
2340924
Compare
Closed
mysociety-pusher
force-pushed
the
remove-unicode-gbp
branch
from
2340924 to
442580d
Compare
garethrees
approved these changes
Oct 15, 2020
We can replace the unicode gem completely for Ruby 2.4+ by using the core `#upcase` method which now has "Full Unicode case mapping" by default [1]. [1] https://ruby-doc.org/core-2.4.0/String.html#method-i-downcase
gbp
force-pushed
the
remove-unicode-gbp
branch
from
442580d to
7fcf2b9
Compare
This was referenced Oct 15, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Requires mysociety/commonlib#72
What does this do?
For Ruby 2.4+ this now uses core Ruby string
#upcasemethod instead of using the Unicode gem. This seems to helpped with issues various issues seen in production.Once #5222 is done we can remove the gem completely.
Closes #5870 #5871 #5873 #5874 #5876 #5877 #5878 #5879