[ERROR] public_body#list (TypeError) "no implicit conversion of false into Integer"

[garethrees]

A TypeError occurred in public_body#list:

no implicit conversion of false into Integer
app/controllers/public_body_controller.rb:120:in `upcase'


-------------------------------
Request:
-------------------------------

* URL : https://www.whatdotheyknow.com/cy/body/list/m?page=5
* HTTP Method: GET
* Parameters : {"page"=>"5", "controller"=>"public_body", "action"=>"list", "tag"=>"m", "locale"=>"cy"}
* Timestamp : 2020-08-19 10:10:45 +0100
* Server : owl
* Rails root : /data/vhost/www.whatdotheyknow.com/alaveteli-2020-08-14T14-54-29
* Process: 6960

-------------------------------
Session:
-------------------------------

* session id: [FILTERED]
* data: {"session_id"=>"30b86bcae4fad173cf9e6a1825efc3f6", "locale"=>"cy"}

-------------------------------
Backtrace:
-------------------------------

app/controllers/public_body_controller.rb:120:in `upcase'
app/controllers/public_body_controller.rb:120:in `list'
app/controllers/application_controller.rb:111:in `record_memory'
lib/strip_empty_sessions.rb:15:in `call'

[garethrees]

# Passing false to upcase as the exception suggests is happening:
Unicode.upcase(false)
# => TypeError: wrong argument type false (expected String)

# Maybe its something else on the same line? Nope…
@tag = false
Unicode.upcase(@tag) if @tag.scan(/./mu).size == 1
# => NoMethodError: undefined method `scan' for false:FalseClass

[garethrees]

I think #5871 might be the underlying cause of this one.

[garethrees]

Backtrace after cdccd2a

-------------------------------
Backtrace:
-------------------------------

  app/controllers/public_body_controller.rb:120:in `upcase'
  app/controllers/public_body_controller.rb:120:in `list'
  app/controllers/application_controller.rb:111:in `record_memory'
  lib/strip_empty_sessions.rb:15:in `call'

[gbp]

Out of the other similar issues, I think this is the only one which might need more work to replace calls (1 2 3) to Unicode.upcase. The Unicode gem can then be removed

[garethrees]

Nice!

[gbp]

Closing after #5907