Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERROR] public_body#show (TypeError) "no implicit conversion of false into Integer" #5871

Closed
garethrees opened this issue Aug 18, 2020 · 2 comments
Labels
bug Breaks expected functionality f:authorities x:uk

Comments

@garethrees
Copy link
Member

A TypeError occurred in public_body#show:

no implicit conversion of false into Integer
app/controllers/public_body_controller.rb:24:in `show'


-------------------------------
Request:
-------------------------------

* URL : https://www.whatdotheyknow.com/body/king_edward_vi_grammar_school_chelmsford/unsuccessful
* HTTP Method: GET
* IP address : 114.119.167.151
* Parameters : {"view"=>"unsuccessful", "controller"=>"public_body", "action"=>"show", "url_name"=>"king_edward_vi_grammar_school_chelmsford"}
* Timestamp : 2020-08-18 06:00:30 +0100
* Server : owl
* Rails root : /data/vhost/www.whatdotheyknow.com/alaveteli-2020-08-14T14-54-29
* Process: 5790

-------------------------------
Session:
-------------------------------

* session id: [FILTERED]
* data: {"session_id"=>"0ee5c2158384e73fbdac0f8cb02c5cb4", "locale"=>"en"}

-------------------------------
Environment:
-------------------------------

* HTTP_ACCEPT : text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
* HTTP_ACCEPT_ENCODING : gzip
* HTTP_ACCEPT_LANGUAGE : en,zh;q=0.1
* HTTP_HOST : www.whatdotheyknow.com
* HTTP_USER_AGENT : Mozilla/5.0 (Linux; Android 7.0;) AppleWebKit/537.36 (KHTML, like Gecko) Mobile Safari/537.36 (compatible; PetalBot;+https://aspiegel.com/petalbot)
* HTTP_VERSION : HTTP/1.1
* HTTP_X_FORWARDED_PROTO : https

-------------------------------
Backtrace:
-------------------------------

app/controllers/public_body_controller.rb:24:in `show'
app/controllers/application_controller.rb:111:in `record_memory'
lib/strip_empty_sessions.rb:15:in `call'
@garethrees garethrees added x:uk bug Breaks expected functionality f:authorities labels Aug 18, 2020
@garethrees
Copy link
Member Author

Similar to #5870, the URL works for me.

mysociety-pusher pushed a commit that referenced this issue Aug 27, 2020
There seems to be an issue with `MySociety::Format.simplify_url_part`
but we're not getting a full stack trace due to the source being outside
of app/lib.

This change should hopefully give us more information to allow us to
debug this issue.

See:
  #5870
  #5871
  #5873
  #5874
  #5876
  #5877
  #5878
  #5879
mysociety-pusher pushed a commit that referenced this issue Aug 30, 2020
There seems to be an issue with `MySociety::Format.simplify_url_part`
but we're not getting a full stack trace due to the source being outside
of app/lib.

This change should hopefully give us more information to allow us to
debug this issue.

See:
  #5870
  #5871
  #5873
  #5874
  #5876
  #5877
  #5878
  #5879
mysociety-pusher pushed a commit that referenced this issue Sep 10, 2020
There seems to be an issue with `MySociety::Format.simplify_url_part`
but we're not getting a full stack trace due to the source being outside
of app/lib.

This change should hopefully give us more information to allow us to
debug this issue.

See:
  #5870
  #5871
  #5873
  #5874
  #5876
  #5877
  #5878
  #5879
@gbp
Copy link
Member

gbp commented Oct 15, 2020

Closing after #5907

@gbp gbp closed this as completed Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks expected functionality f:authorities x:uk
Projects
None yet
Development

No branches or pull requests

2 participants