Display translations on failed validation

[garethrees]

HOTFIX (Moved from #2154)

Merge in to rails-3-develop

ac907d7 built the translations in the controller rather than the view.

In a request that contains no params for a translation and fails
validation the translation is no longer available to the view. This
commit builds the translations in the case of a failed validation.

Fixes issue brought up in #2140 (comment)

Also fixes #2112, #2113

[garethrees]

I think this works in most cases now, but if the PublicBody fails validation the PublicBody::Translation is persisted without a public_body_id. #2142 should prevent this, but we'd have to include both in the hotfix.

[garethrees]

I think we can just call @category.translation here which seems to add the default locale in to the translations array:

> category = FactoryGirl.build(:public_body_category)
=> #<PublicBodyCategory id: nil, title: "Example Public Body Category 6", category_tag: "example_tag_6", description: "Example Public body Description 6">
> category.translations
=> []
> category.translation
=> #<PublicBodyCategory::Translation id: nil, public_body_category_id: nil, locale: "en", description: nil, title: nil, created_at: nil, updated_at: nil>
> category.translations
=> [#<PublicBodyCategory::Translation id: nil, public_body_category_id: nil, locale: "en", description: nil, title: nil, created_at: nil, updated_at: nil>]

[crowbot]

Probably translation.locale.to_s would be a better fallback here than _("Default locale") as this is not necessarily the default locale.

[crowbot]

My only question here now is whether it's clear enough what the problem is when the category heading translations in particular fail validation. I've made some commits in #2219 that I think might help. 7929e1b seems like an obvious improvement to the admin interface in general. 533e99b breaks out the error messages and highlights the translation they belong to. ac207f7 fixes the issue that the fields on the default locale aren't getting highlighted because the errors are on the model itself, but probably going back to a pattern like 6b0a79a#diff-e9be0b7887688275035d3346ae523a01R18 is a cleaner fix.

[garethrees]

going back to a pattern like 6b0a79a#diff-e9be0b7887688275035d3346ae523a01R18 is a cleaner fix.

Yeah, done.

Also highlighted the tab 3b0bfb5

[garethrees]

I don't think these if statements are needed - should be handled by built-in validation

Ah yep, removed.

I'll drop 3b0bfb5, merge the fixups and make a PR against rails-3-develop

[garethrees]

See #2166