[#2113] Fix admin form translations #2140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethrees
added a commit
that referenced
this pull request
Feb 4, 2015
Validate the translated attributes of a PublicBodyCategory. Validations (and counterpart specs) are defined in the same file as PublicBodyCategory since the validations must be added after PublicBodyCategory is loaded. TODO: Render errors in the form. Waiting on #2140
crowbot
force-pushed
the
2113-admin-form-translations
branch
2 times, most recently
from
8e5806f to
f65d506
Compare
|
There's a problem here that I think also applies to #2127, so sorry to notice it belatedly - if validation fails, locales whose forms were empty aren't shown in the subsequent form. This applies to both new/create and edit/update actions
|
Fixes submission of form containing both existing and new translations
Fixes submission of form containing both existing and new translations
mysociety-pusher
force-pushed
the
2113-admin-form-translations
branch
from
f65d506 to
168b218
Compare
|
I think c2e1f22#commitcomment-9734962 applies here |
Strangely it seems like these don't suffer from an orphan translation on failed validation (#2166 (comment)). I expect this is also related to not having to build the transation for the default locale on failed update (3c77b85#diff-31db1e3c6a378d1f5464538c869ef4d9R20, 6de375c#diff-9fb12d9f60bb7aa9f070e38655b5771cR62) |
|
This needs to be hotfixed on to master, so moved these commits to the existing PR at #2166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2113
Requires #2127 (for theconfig/test.ymladdition 5b776d1)