Require a description for a PublicBodyCategory translation

[garethrees]

Given a PublicBody is marked with a tag that relates to a PublicBodyCategory,
When you visit the "show" page of that PublicBody where the PublicBodyCategory does not have a description in the current locale
Then there should be no error.

A TypeError occurred in public_body#show:

can't convert nil into String
app/models/public_body.rb:347:in `+'

Need to add a validation on PublicBodyCategory to ensure all locales have a description if the primary locale contains a description.

Alternatively, modify PublicBody#type_of_authority to only try to render the description if it's available in the current locale.

https://github.com/mysociety/alaveteli/blob/rails-3-develop/app/models/public_body.rb#L347

[lizconlan]

had a similar issue on Panama last week - #2105

possibly related, is the check at app/models/public_body.rb:344 looking at the right thing, or should there be an additional check that the lookup has found something?

[garethrees]

possibly related, is the check at app/models/public_body.rb:344 looking at the right thing, or should there be an additional check that the lookup has found something?

It looks like it's used so that it only capitalises the first result. It should probably also check that it's found something.

[garethrees]

We actually validate that a PublicBodyCategory has a description (#2012), so that should probably be true for the translated versions.

[garethrees]

This ticket is pretty much wontfix, since it's expecting a description to be there.

[garethrees]

Renamed the ticket to reference what the fix should be.

A translation of a PublicBodyCategory should not be valid if its description attribute is empty.

[crowbot]

Covered in #2140