-
Notifications
You must be signed in to change notification settings - Fork 133
clear NSMainNibFile entry in Info.plist #442
Conversation
Hi @funkybaboon, thanks for submitting this PR. Could you please specify in more detail under which circumstances this fix is necessary. I'm currently not aware of any problems with the hook. @MathiasTim @lordgreg @DrMabuse23 what do you think? |
@gruppjo Yes, this is required. @funkybaboon is on our team ;) |
I should add this is, from my side, a hotfix which could be removed as soon as @TooTallNate (https://github.com/TooTallNate) fixes or PR's into master. This is actually the plist node module issue and has already be found and reported there: TooTallNate/plist.js#79 and TooTallNate/plist.js#75 The module doesn't properly parse nullified values of keys. This has been found only with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice if this fix / workaround would be a single file its more easy to maintain and it looks like the standard ionic update_platform.js, maybe on the next update we loose the changes.
Hear ye, hear ye! The whole 'update of hook js file' can be avoided if we take the updated/fixed version of plist, which was already made as Pull Request by @akofman (PR can be seen here: TooTallNate/plist.js#81). Until @TooTallNate merges his updates to master, I suggest using exactly this commit in
|
+1 |
Will open a new PR |
This fixes an invalid entry in the Info.plist (https://forum.ionicframework.com/t/xcode-main-interface-nsmainnibfile-ipad/66942).
NSMainNibFiles define which orientation the App is allowed to run. Nowadays this is set in the UISupportedInterfaceOrientations entry in the Info.plist. The App crashes if you have both in your Info.plist:
The hook removes both NSMainNibFile entries completely.