-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Xcode errors #81
Conversation
Any idea when this will be merged? @akofman's fix worked for me (tested with his fork) |
Would be nice if this could be merged as it fixes the issues I am having with this library. |
why is this PR causing tests to fail? |
Hello @mreinstein, I can't access the Travis logs for this project so I can't check why the tests fail ... Could you have a look at that ? |
@ZauberNerd Nice ! Thanks for that. |
Why was this never merged? The problem #79 still exists |
@cmaart @mreinstein because after the fixes in #84 have been merged it hasn't been released to npm again. |
Can you please publish the fixed version to NPM? |
published 2.1.0. Sorry for the delay! |
Thank you! 👌🏼😁 |
Hello,
Just a fix that ensures String values are never null in order to prevent XCode issues as described in #79.
Also, if a key is null it won't be added anymore to the parsed object. With the actual version, if
a key is null, its value is used as a key :/
Thanks !