Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Xcode errors #81

Closed
wants to merge 2 commits into from
Closed

Prevent Xcode errors #81

wants to merge 2 commits into from

Conversation

akofman
Copy link

@akofman akofman commented Sep 21, 2016

Hello,

Just a fix that ensures String values are never null in order to prevent XCode issues as described in #79.
Also, if a key is null it won't be added anymore to the parsed object. With the actual version, if
a key is null, its value is used as a key :/

Thanks !

@otmezger
Copy link

otmezger commented Oct 9, 2016

Any idea when this will be merged? @akofman's fix worked for me (tested with his fork)

@sanderkoenders
Copy link

Would be nice if this could be merged as it fixes the issues I am having with this library.

@mreinstein
Copy link
Collaborator

why is this PR causing tests to fail?

@akofman
Copy link
Author

akofman commented Jan 10, 2017

Hello @mreinstein, I can't access the Travis logs for this project so I can't check why the tests fail ... Could you have a look at that ?
Tests are ok if I run them locally so I guess it's maybe a node version issue. Also it looks like every PR have the same issue on this project.

@ZauberNerd
Copy link
Contributor

@akofman I believe this is fixed with #84 so this PR could be closed.

@akofman
Copy link
Author

akofman commented Feb 20, 2017

@ZauberNerd Nice ! Thanks for that.

@akofman akofman closed this Feb 20, 2017
@cmaart
Copy link

cmaart commented Mar 29, 2017

Why was this never merged? The problem #79 still exists

@ZauberNerd
Copy link
Contributor

@cmaart @mreinstein because after the fixes in #84 have been merged it hasn't been released to npm again.

@biesbjerg
Copy link

Can you please publish the fixed version to NPM?

@mreinstein
Copy link
Collaborator

published 2.1.0. Sorry for the delay!

@biesbjerg
Copy link

Thank you! 👌🏼😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants