Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

point plist module to a commit that fixes the plist generation with e… #445

Merged
merged 1 commit into from
Oct 27, 2016
Merged

point plist module to a commit that fixes the plist generation with e… #445

merged 1 commit into from
Oct 27, 2016

Conversation

funkybaboon
Copy link
Contributor

@funkybaboon funkybaboon commented Oct 26, 2016

Fix issue with empty plist keys by using @lordgreg's solution

See #442

@coveralls
Copy link

coveralls commented Oct 26, 2016

Coverage Status

Coverage remained the same at 97.959% when pulling a737df2 on funkybaboon:fix_plist_module into 23570b4 on mwaylabs:master.

@gruppjo
Copy link
Contributor

gruppjo commented Oct 26, 2016

Hey everybody, thanks for shedding some light.

Since this is only a workaround I'd rather open an issue with a descriptions on how to fix this until a fixed version of plist.js is available. If we lock the version of plist to a specific commit, we'll need to revert this change in a later version.

So I see two options:

  1. publish a bugfix version of the generator, but one of you will have to keep in mind to revert the version lock of plist once it's fixed
  2. instead we open an issue with a short description on how to deal with this problem until it fixes itself without any changes in the generator.

@funkybaboon, @MathiasTim, @lordgreg, @DrMabuse23 please vote with 👍 for option 1. or 👎 for option 2.

@MathiasTim
Copy link
Contributor

MathiasTim commented Oct 26, 2016

I have to vote 👍 we are having (not just here) some issues with keeping versions soft with e.g. cordova: "^6.0.0" instead of cordova: "~6.0.0". Because people do breaking changes in feature releases. Thats why im completely fine with hardcoding to a specific commit because in my opinion it's easier to maintain then the other way round.

@gruppjo
Copy link
Contributor

gruppjo commented Oct 26, 2016

@funkybaboon, welcome to the team :)

@gruppjo gruppjo merged commit 921df3c into mwaylabs:master Oct 27, 2016
@gruppjo
Copy link
Contributor

gruppjo commented Oct 27, 2016

@lordgreg, @MathiasTim, @funkybaboon. Published in version 1.10.1 https://github.com/mwaylabs/generator-m-ionic/releases/tag/1.10.1

Please keep me updated, I don't want to see this dependency become unnecessarily outdated. @lordgreg, will you let me know?

@lordgreg
Copy link
Contributor

@gruppjo Maybe. 🎱

@gruppjo
Copy link
Contributor

gruppjo commented Oct 27, 2016

Ever heard of npm unpublish? #npmgate #youbetter

@funkybaboon funkybaboon deleted the fix_plist_module branch March 21, 2017 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants