Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of mult expression var * var #161

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix parsing of mult expression var * var #161

merged 1 commit into from
Jan 20, 2022

Conversation

stuboydl
Copy link
Contributor

Fix label must be start of line
Fix highlight ";" not part of comment

Fix label must be start of line
Fix highlight ";" not part of comment
@stuboydl
Copy link
Contributor Author

stuboydl commented Oct 18, 2021

Current syntax highlighter regex does not parse multiplication expressions properly and will cause remainder of line after the asterisk to be highlighted as comment.

abc * def ...
    ^------------->

This change fixes that; also that label should be at hard start of line; also does not highlight preceeding semicolon as part of comment in an in-line comment.

@itsxallwater itsxallwater self-requested a review October 18, 2021 22:12
@itsxallwater itsxallwater self-assigned this Oct 18, 2021
@itsxallwater
Copy link
Member

Thanks @stuboydl will put this on my to do list. May be a minute but we're due for some package updates here anyway so it will be good to get a few things added in.

@itsxallwater
Copy link
Member

Gearing up for 2.1.3 to fix a major issue with the latest VS Code versions. Will include this change for testing and release.

@itsxallwater itsxallwater merged commit eb68196 into mvextensions:develop Jan 20, 2022
itsxallwater added a commit that referenced this pull request Jan 27, 2022
* add dom to tsconfig for client

* added to FormData.d.ts (reference to Blob) and fixed duplicate autocomplete for GO/GOSUB/GO TO/GOTO (#147)

* Update language-configuration.json (#150)

* RestFS and Package Updates (#164)

* package updates + restfs switch to axios

* Still not there but latest code for Pete

* Update axios response for rest calls.

* Prep work for 2.1.3 release

* Added _response_object() function to check response body. Fixed some arguments for Axios calls. Updated REST documentation.

* Latest package updates

Co-authored-by: Peter Schellenbach <[email protected]>

* Fix parsing of mult expression var * var (#161)

Fix label must be start of line
Fix highlight ";" not part of comment

Co-authored-by: Stuart Boydell <[email protected]>

* Prep 2.1.3 release

* Add new 'Auto Close' setting for RestFS

* Fixes to rename, writeFile

* Remove AutoClose setting for RestFS

* Cleaned up RestFS handling of failure status codes (axios). Added FTSERVER launch config. Updated RestFS documentation.

Co-authored-by: Ted <[email protected]>
Co-authored-by: andrewcole50 <[email protected]>
Co-authored-by: Peter Schellenbach <[email protected]>
Co-authored-by: stuboydl <[email protected]>
Co-authored-by: Stuart Boydell <[email protected]>
@stuboydl stuboydl deleted the issue161 branch August 29, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants