Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CTRL|CMD + / Hotkey #150

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix CTRL|CMD + / Hotkey #150

merged 1 commit into from
Mar 12, 2021

Conversation

andrewcole50
Copy link
Contributor

Fixes CTRL|CMD + / hot key for adding/removing comments

Re #139

@itsxallwater itsxallwater self-assigned this Mar 11, 2021
@itsxallwater
Copy link
Member

I'm okay with merging but wanted to pitch a thought--do you think there's a way we could have the config drive this for people? So that a user might specify if they want it to be * or !.

I always used * but a colleague told me he prefers ! and the reason is then he can reliably search code for * and expect to find math operations. Interesting.

@andrewcole50
Copy link
Contributor Author

I'm okay with merging but wanted to pitch a thought--do you think there's a way we could have the config drive this for people? So that a user might specify if they want it to be * or !.

I always used * but a colleague told me he prefers ! and the reason is then he can reliably search code for * and expect to find math operations. Interesting.

Very interesting; that's totally logical too. I just tested and we could hack the unused block comments for that but it would be rather strange. VScode doesn't account for multiple types of line comments and I saw they already have an open issue about that in regards to the Dart language. The downside of hacking block comments is you have to provide a closing character (I used another !) and you have to highlight the line you want commented.

@itsxallwater
Copy link
Member

Something to chew on. Maybe we push this PR as-is for now.

@itsxallwater itsxallwater merged commit c15e17f into mvextensions:develop Mar 12, 2021
@itsxallwater itsxallwater added this to the v2.1.3 milestone Mar 12, 2021
itsxallwater added a commit that referenced this pull request Jan 27, 2022
@itsxallwater @TedCha
@andrewcole50 @stuboydl
v2.1.3 Release (#165)
39e5da0 
* add dom to tsconfig for client

* added to FormData.d.ts (reference to Blob) and fixed duplicate autocomplete for GO/GOSUB/GO TO/GOTO (#147)

* Update language-configuration.json (#150)

* RestFS and Package Updates (#164)

* package updates + restfs switch to axios

* Still not there but latest code for Pete

* Update axios response for rest calls.

* Prep work for 2.1.3 release

* Added _response_object() function to check response body. Fixed some arguments for Axios calls. Updated REST documentation.

* Latest package updates

Co-authored-by: Peter Schellenbach <[email protected]>

* Fix parsing of mult expression var * var (#161)

Fix label must be start of line
Fix highlight ";" not part of comment

Co-authored-by: Stuart Boydell <[email protected]>

* Prep 2.1.3 release

* Add new 'Auto Close' setting for RestFS

* Fixes to rename, writeFile

* Remove AutoClose setting for RestFS

* Cleaned up RestFS handling of failure status codes (axios). Added FTSERVER launch config. Updated RestFS documentation.

Co-authored-by: Ted <[email protected]>
Co-authored-by: andrewcole50 <[email protected]>
Co-authored-by: Peter Schellenbach <[email protected]>
Co-authored-by: stuboydl <[email protected]>
Co-authored-by: Stuart Boydell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsxallwater itsxallwater itsxallwater approved these changes

Assignees

@itsxallwater itsxallwater

Labels
None yet
Projects
None yet
Milestone
v2.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewcole50 @itsxallwater