Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duplicate auto-suggest labels for GO/GOSUB/GO TO/GOTO IntelliSense Statements #147

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Fixed duplicate auto-suggest labels for GO/GOSUB/GO TO/GOTO IntelliSense Statements #147

merged 1 commit into from
Mar 11, 2021

Conversation

TedCha
Copy link
Contributor

@TedCha TedCha commented Mar 7, 2021 •
edited
Loading

The issue was that every label would be added without checking if it already existed within the Intellisense object. It now will check if the label exists in the Intellisense object before adding it.

Issue: #127

@kpowick
Copy link
Member

kpowick commented Mar 7, 2021

Hi @tcharts-boop

Thanks for your help on this item.

Just a FYI. All pull requests should be for the project's develop branch. Once develop achieves stability and includes desired milestones, the changes are pulled into main for a new public release of mvExtensions.

A while back, the decision was made for the main branch to only represent the current public release of mvExtensions.

Bearing that in mind, it's probably best to set up your own repo that way, so pull requests are from your develop branch to the project's develop branch.

Again, thanks for taking on this issue. The more help, the better!

@kpowick kpowick linked an issue Mar 7, 2021 that may be closed by this pull request
[BUG] Auto-Complete list of subroutines keeps growing, and across tabs #127
Closed
@TedCha
Copy link
Contributor Author

TedCha commented Mar 7, 2021

Ahh understood. I’ll set up my developer environment to reflect what you suggest so in the future I’m adhering to the project’s guidelines. Thanks!

@TedCha
Copy link
Contributor Author

TedCha commented Mar 7, 2021

@kpowick, would you like me to close this merge request and reopen it to merge onto the develop branch?

@kpowick
Copy link
Member

kpowick commented Mar 8, 2021

@tcharts-boop You should be able to edit this request and change the branch to develop. See the Edit button beside the PR heading.

@TedCha TedCha changed the base branch from main to develop March 8, 2021 16:44
@itsxallwater itsxallwater deleted the branch mvextensions:develop March 10, 2021 20:56
@itsxallwater
Copy link
Member

Looks like this one was able to be re-opened unlike #139

@itsxallwater itsxallwater reopened this Mar 10, 2021
@itsxallwater itsxallwater self-assigned this Mar 11, 2021
@itsxallwater itsxallwater self-requested a review March 11, 2021 04:48
@itsxallwater itsxallwater added this to the v2.1.3 milestone Mar 11, 2021
@itsxallwater
Copy link
Member

Nice fix!

@itsxallwater itsxallwater merged commit ee34882 into mvextensions:develop Mar 11, 2021
itsxallwater added a commit that referenced this pull request Jan 27, 2022
@itsxallwater @TedCha
@andrewcole50 @stuboydl
v2.1.3 Release (#165)
39e5da0 
* add dom to tsconfig for client

* added to FormData.d.ts (reference to Blob) and fixed duplicate autocomplete for GO/GOSUB/GO TO/GOTO (#147)

* Update language-configuration.json (#150)

* RestFS and Package Updates (#164)

* package updates + restfs switch to axios

* Still not there but latest code for Pete

* Update axios response for rest calls.

* Prep work for 2.1.3 release

* Added _response_object() function to check response body. Fixed some arguments for Axios calls. Updated REST documentation.

* Latest package updates

Co-authored-by: Peter Schellenbach <[email protected]>

* Fix parsing of mult expression var * var (#161)

Fix label must be start of line
Fix highlight ";" not part of comment

Co-authored-by: Stuart Boydell <[email protected]>

* Prep 2.1.3 release

* Add new 'Auto Close' setting for RestFS

* Fixes to rename, writeFile

* Remove AutoClose setting for RestFS

* Cleaned up RestFS handling of failure status codes (axios). Added FTSERVER launch config. Updated RestFS documentation.

Co-authored-by: Ted <[email protected]>
Co-authored-by: andrewcole50 <[email protected]>
Co-authored-by: Peter Schellenbach <[email protected]>
Co-authored-by: stuboydl <[email protected]>
Co-authored-by: Stuart Boydell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsxallwater itsxallwater itsxallwater approved these changes

Assignees

@itsxallwater itsxallwater

Labels
None yet
Projects
None yet
Milestone
v2.1.3
Development

Successfully merging this pull request may close these issues.

[BUG] Auto-Complete list of subroutines keeps growing, and across tabs
3 participants
@TedCha @kpowick @itsxallwater