[Chip][material-ui] Add cursor CSS property reset #38984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
component: chip
Netlify deploy previewhttps://deploy-preview-38984--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
approved these changes
Sep 15, 2023
danilo-leal
changed the title
2 tasks
danilo-leal
pushed a commit
to siriwatknp/material-ui
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #38958
The
cursor: "default"style was removed in #38076. This introduced #38958.When
ButtonBaseis used (on clickable and deletable chips), this component'scursor: "pointer"is added. We must explicitly reset thecursorCSS property using theautokeyword. This will set the property to its initial value while allowing it to be inherited from the parent, maintaining #38076 's original goal.(
cursor: "pointer"is added back for clickable chips)