Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chip][material] Fix base cursor style to be "auto" not "default" #38076

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Jul 20, 2023

Found in: #38025

Following up on this comment: #38025 (review), update the Chip's cursor to be auto (which is the default value for the cursor property), that way the cursor type is determined given the chip's context. It will still be set to pointer if clickable is true.

This brings it closer to Joy's implementation as well.

@DiegoAndai DiegoAndai added component: chip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jul 20, 2023
@DiegoAndai DiegoAndai self-assigned this Jul 20, 2023
@DiegoAndai DiegoAndai changed the title [Chip][material] set cursor to auto [Chip][material] set cursor to auto for base styles Jul 20, 2023
@DiegoAndai DiegoAndai changed the title [Chip][material] set cursor to auto for base styles [Chip][material] set cursor to auto for the Chip component's base style Jul 20, 2023
@mui-bot
Copy link

mui-bot commented Jul 20, 2023

Netlify deploy preview

https://deploy-preview-38076--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 3d9dae1

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jul 20, 2023
@oliviertassinari oliviertassinari changed the title [Chip][material] set cursor to auto for the Chip component's base style [Chip][material] Fix base cursor style to be "auto" not "default" Jul 20, 2023
@DiegoAndai DiegoAndai requested a review from danilo-leal July 20, 2023 21:35
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🤙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: chip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants