Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Chip] Deletable variant has cursor: pointer style #38999

Closed
2 tasks done
Semigradsky opened this issue Sep 15, 2023 · 2 comments
Closed
2 tasks done

[material-ui][Chip] Deletable variant has cursor: pointer style #38999

Semigradsky opened this issue Sep 15, 2023 · 2 comments
Labels
component: chip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material

Comments

@Semigradsky
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example: https://mui.com/material-ui/react-chip/#deletable

Current behavior 😯

The deletable chip has cursor: pointer style.

Expected behavior 🤔

The deletable chip shouldn't have cursor: pointer style, only delete icon.

Context 🔦

Here we add cursor: 'pointer', only if ownerState.clickable is true:

I debugged it and saw that ownerState.clickable is false for deletable chip. I think that we have cursor: pointer from ButtonBase styles:

Your environment 🌎

  System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
  Binaries:
    Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
    Yarn: 3.6.3 - ~/.nvm/versions/node/v18.15.0/bin/yarn
    npm: 9.5.0 - ~/.nvm/versions/node/v18.15.0/bin/npm
  Browsers:
    Chrome: Not Found
  npmPackages:
    @emotion/react:  11.11.0
    @emotion/styled:  11.11.0
    @mui/base:  5.0.0-beta.9
    @mui/core-downloads-tracker:  5.14.3
    @mui/lab:  5.0.0-alpha.138
    @mui/material:  5.14.3
    @mui/private-theming:  5.13.7
    @mui/styled-engine:  5.13.2
    @mui/system:  5.14.3
    @mui/types:  7.2.4
    @mui/utils:  5.14.3
    @mui/x-data-grid:  5.11.1
    @mui/x-date-pickers:  6.7.0
    @mui/x-tree-view:  6.0.0-alpha.0
    @types/react:  18.2.6
    react:  18.2.0
    react-dom:  18.2.0
    typescript: ^5.0.2 => 5.0.4
@Semigradsky Semigradsky added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 15, 2023
@danilo-leal danilo-leal changed the title Deletable Chip has cursor: pointer style [material-ui][Chip] Deletable variant has cursor: pointer style Sep 15, 2023
@danilo-leal danilo-leal added component: chip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 15, 2023
@danilo-leal
Copy link
Contributor

danilo-leal commented Sep 15, 2023

Hey @Semigradsky, thanks for the issue! I think @DiegoAndai has just fixed this problem with #38984?
Will be up with next week's release!

@Semigradsky
Copy link
Contributor Author

Oh, cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: chip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

No branches or pull requests

2 participants