Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] fix click and type simultaneously. #3055

Merged
merged 1 commit into from
Feb 9, 2016
Merged

[TextField] fix click and type simultaneously. #3055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TextField/TextField.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ const TextField = React.createClass({
},
floatingLabel: {
color: hintColor,
pointerEvents: 'none',
},
input: {
tapHighlightColor: 'rgba(0,0,0,0)',
Expand Down Expand Up @@ -467,7 +468,6 @@ const TextField = React.createClass({
htmlFor={inputId}
shrink={this.state.hasValue || this.state.isFocused}
disabled={disabled}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced by #2228.
Is the browser support of pointerEvents enough to remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't recreate #2228 on Chrome for windows with this fix applied.

onTouchTap={this.focus}
>
{floatingLabelText}
</TextFieldLabel>
Expand Down