[TextField] Fix for floating label element not allowing focus #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -309,7 +310,8 @@ const TextField = React.createClass({ | |||
| let floatingLabelTextElement = floatingLabelText ? ( | |||
| <label | |||
| style={this.prepareStyles(styles.floatingLabel, this.props.floatingLabelStyle)} | |||
| htmlFor={inputId}> | |||
| htmlFor={inputId} | |||
| onClick={this.focus}> | |||
There was a problem hiding this comment.
I think that it should be onTouchTap={ instead.
|
@pandaiolo It's working fine for me with this fix 👍. Could you squash down the commit? I will merge then. |
This is a regression bug from mui#2078
|
Squashed! |
|
@pandaiolo Thanks! (The CI fail has nothing to do with this PR) |
oliviertassinari
added a commit
that referenced
this pull request
Nov 21, 2015
[TextField] Fix for floating label element not allowing focus
zannager
added
the
component: text field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression bug from #2078. The floating label was set with a zIndex of 1, which moves it on top of the input element. The click events on the floating label do not reach input element, hence not allowing focus.
Also, the cursor became an arrow instead of
text, because the floating labeldivis on top, which is an unexpected visual feedback on a text field.OSX El Capitan, Chrome Version 46.0.2490.86 (64-bit)