Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] fix click and type simultaneously. #3055

Merged
merged 1 commit into from
Feb 9, 2016
Merged

[TextField] fix click and type simultaneously. #3055

merged 1 commit into from
Feb 9, 2016

Conversation

chrismcv
Copy link
Contributor

#3045 fixed

oliviertassinari
oliviertassinari reviewed Jan 26, 2016
View reviewed changes
src/TextField/TextField.jsx
@@ -467,7 +468,6 @@ const TextField = React.createClass({
htmlFor={inputId}
shrink={this.state.hasValue || this.state.isFocused}
disabled={disabled}
onTouchTap={this.focus}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced by #2228.
Is the browser support of pointerEvents enough to remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't recreate #2228 on Chrome for windows with this fix applied.

@oliviertassinari
Copy link
Member

I'm wondering if this won't solve other opened issues related to the the focus of the input field.

@chrismcv chrismcv closed this Feb 1, 2016
@chrismcv chrismcv deleted the text-field-fix branch February 1, 2016 21:12
@oliviertassinari
Copy link
Member

@chrismcv Hey, why did you close your PR?

@chrismcv chrismcv restored the text-field-fix branch February 1, 2016 21:32
@chrismcv
Copy link
Contributor Author

chrismcv commented Feb 1, 2016

whoops! was having a cleanup on my fork and got rid of that by mistake

@chrismcv chrismcv reopened this Feb 1, 2016
@newoga
Copy link
Contributor

newoga commented Feb 8, 2016

@oliviertassinari @alitaheri Are we waiting on anything before merging this?

@chrismcv
Copy link
Contributor Author

chrismcv commented Feb 8, 2016

I'm not sure - I tried to recreate the issue from the original PR, but couldn't.

@oliviertassinari oliviertassinari mentioned this pull request Feb 8, 2016
Merged
oliviertassinari added a commit that referenced this pull request Feb 9, 2016
@oliviertassinari
Merge pull request #3055 from chrismcv/text-field-fix
15f2f3e 
[TextField] fix click and type simultaneously.
@oliviertassinari oliviertassinari merged commit 15f2f3e into mui:master Feb 9, 2016
@oliviertassinari
Copy link
Member

@chrismcv I wasn't able to reproduce the issue. But it's should be safe to apply this change 👍.

@oliviertassinari oliviertassinari mentioned this pull request Feb 10, 2016
Merged
@zannager zannager added the component: text field This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrismcv @oliviertassinari @newoga @zannager