Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatePicker] multiple small layout fixes #1552

Closed
wants to merge 3 commits into from
Closed

[DatePicker] multiple small layout fixes #1552

wants to merge 3 commits into from

Conversation

Dolmio
Copy link

@Dolmio Dolmio commented Aug 30, 2015

Fixes multiple layout issues with DatePicker:
1.
From:
screenshot 2015-08-30 13 18 20
To:
screenshot 2015-08-30 13 19 17
1.
From:
screenshot 2015-08-30 13 30 59
To:
screenshot 2015-08-30 13 39 36

From:
screenshot 2015-08-30 13 19 17
To:
screenshot 2015-08-30 13 39 36

@Dolmio
Display last row in DatePicker in safari mui#1489
9542ca7 
In safari button elements get implicit margin,
which meant that the height of day buttons
are higher than expected and caused the rows
not fit to their container.
@Dolmio
Increase the Calendar toolbar height by 1px
b6ad09e 
Fixes the clipping g character in August
@Dolmio
Increase calendarContainer height
5fe7c58 
Increase height by 4px so that the
part of the highlight circle is not
clipped out when a day is selected from
the last row.
@jkruder
Copy link
Contributor

jkruder commented Aug 30, 2015

#1266 refactors the layout making these changes unnecessary.

@Dolmio
Copy link
Author

Dolmio commented Aug 30, 2015

Hah, I missed that completely :) Hopefully we can get the #1266 merged soon?

@jkruder
Copy link
Contributor

jkruder commented Aug 30, 2015

I hope so. Just rebased so we'll see

@Dolmio
Copy link
Author

Dolmio commented Aug 30, 2015

In update-datepicker branch there is still the issue with safari and the last row, which can be fixed with 9542ca7 same goes for b6ad09e

@Dolmio Dolmio mentioned this pull request Aug 31, 2015
Closed
@hai-cea
Copy link
Member

hai-cea commented Sep 7, 2015

#1266 Was just merged. Is there still an issue with layout?

@shaurya947
Copy link
Contributor

Closing this for now. @Dolmio let us know if you're still experiencing issues.

@shaurya947 shaurya947 closed this Sep 29, 2015
@mbrookes
Copy link
Member

mbrookes commented Oct 8, 2015

#1266 doesn't seem to have resolved #1489 unfortunately.

@zannager zannager added component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Dolmio @jkruder @hai-cea @shaurya947 @mbrookes @zannager