-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DatePicker] Update DatePicker #1266
Conversation
Addresses #1261 and mui/mui-x#7293 |
@jkruder Thank you for this! It's working great. Here's some of my feedback:
|
@hai-cea Can do. What spacing issues are you seeing? |
@jkruder Here's a side by side comparison of the profile version. I may be able to do pixel measurements in photoshop if you'd like? |
@hai-cea I should be ok, thanks though. I'll get to work on this list. If you see something else, let me know.
|
@jkruder The green one is actually the correct version. Teal is the current one in MUI. So, spacing should be increased not reduced. |
@hai-cea Thanks! I'll get the updates done soon. |
@hai-cea Updated the docs and addressed spacing issues. |
This looks great, hopefully it will get merged soon. |
@jkruder The picker is looking really great! 👍 Just found 2 small issues:
|
@hai-cea Running into some problems with border-radius and the dialog/paper. Trying to work a solution that does not modify dialog/paper. When I remove the paper background-color the border radius is applied correctly but when there is a background color you do not see the full 2px border radius. |
@jkruder The container with the bgColor should have a border radius style. |
@hai-cea Yes, I added the border radius style to the date display container but the border radius appears to not be applied. I'll push the changes tomorrow so you can take a look. |
2081403
to
79d3ec1
Compare
Can you rebase? :) |
…rom material design.
79d3ec1
to
6a155ff
Compare
Thanks @jkruder @oliviertassinari |
* Open picker by space/enter click * Change new prop name to not conflict with current onOpen * Use only enter to open * Fix comment
DatePicker style has been updated to match updated design for DatePicker components. This introduces some breaking changes/new behaviors: