Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On safari the datepicker doesn't display the last row correctly #1489

Closed
Aaron2Ti opened this issue Aug 24, 2015 · 4 comments · Fixed by #3739
Closed

On safari the datepicker doesn't display the last row correctly #1489

Aaron2Ti opened this issue Aug 24, 2015 · 4 comments · Fixed by #3739
Labels
browser: Safari component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!

Comments

@Aaron2Ti
Copy link

see the following attachments pls

screen shot 2015-08-24 at 15 18 24
screen shot 2015-08-24 at 15 18 39
@Dolmio
Copy link

Dolmio commented Aug 29, 2015

I stumbled to the same problem.

Dolmio added a commit to Dolmio/material-ui that referenced this issue Aug 30, 2015
@Dolmio
Display last row in DatePicker in safari mui#1489
9542ca7 
In safari button elements get implicit margin,
which meant that the height of day buttons
are higher than expected and caused the rows
not fit to their container.
@treo
Copy link
Contributor

treo commented Aug 31, 2015

I ran into the same problem on the IPad, and fixed it the same way @Dolmio did in his commit. So Dolmio please create a pull request :)

Dolmio added a commit to Dolmio/material-ui that referenced this issue Aug 31, 2015
@Dolmio
Display last row in DatePicker in safari mui#1489
3c24691 
In safari button elements get implicit margin,
which meant that the height of day buttons
are higher than expected and caused the rows
not fit to their container.
@Dolmio
Copy link

Dolmio commented Aug 31, 2015

@treo I created an pull request #1552, but I think we will wait for #1266 to be merged before applying the fix for safari.

This was referenced Oct 8, 2015
Closed
Closed
@mdolinin
Copy link

This issue is still reproduced in Safari Version 9.0.3 (11601.4.4)
Material-UI demo v0.14.4 and v0.15.0-alpha.1

@mbrookes mbrookes mentioned this issue Mar 21, 2016
Merged
14 tasks
tintin1343 added a commit to tintin1343/material-ui that referenced this issue Mar 21, 2016
@tintin1343
[Datepicker] Redesign as per material spec
d3dbbec 
Redesign the current Datepicker as per material design spec.
This PR deals with the following:
- [ ] Fixes left pane length
- [ ] Fixes Font weight of left pane date
- [ ] Action buttons are part of calender
- [ ] Action buttons in the year container
- [ ] Vertical Spacing in calendar Month reduced
- [ ] Aligned left and right arrows with days of week
- [ ] Flex design in calender toolbar
- [ ] Incorporated flex design for the overall calender and datepicker
- [ ] Fix both dialog and inline calendar
- [ ] Changed year Selector in Year Container as per Material Spec.

Closes mui#3603
Closes mui#3740
Closes mui#1489
tintin1343 added a commit to tintin1343/material-ui that referenced this issue Mar 24, 2016
@tintin1343
[Datepicker] Redesign as per material spec
9d0d307 
Redesign the current Datepicker as per material design spec.
This PR deals with the following:
- [ ] Fixes left pane length
- [ ] Fixes Font weight of left pane date
- [ ] Action buttons are part of calender
- [ ] Action buttons in the year container
- [ ] Vertical Spacing in calendar Month reduced
- [ ] Aligned left and right arrows with days of week
- [ ] Flex design in calender toolbar
- [ ] Incorporated flex design for the overall calender and datepicker
- [ ] Fix both dialog and inline calendar
- [ ] Changed year Selector in Year Container as per Material Spec.

Closes mui#3603
Closes mui#3740
Closes mui#1489
Closes callemall/material-ui#3786
tintin1343 added a commit to tintin1343/material-ui that referenced this issue Mar 28, 2016
@tintin1343
[Datepicker] Redesign as per material spec
b026992 
Redesign the current Datepicker as per material design spec.
This PR deals with the following:
- [ ] Fixes left pane length
- [ ] Fixes Font weight of left pane date
- [ ] Action buttons are part of calender
- [ ] Action buttons in the year container
- [ ] Vertical Spacing in calendar Month reduced
- [ ] Aligned left and right arrows with days of week
- [ ] Flex design in calender toolbar
- [ ] Incorporated flex design for the overall calender and datepicker
- [ ] Fix both dialog and inline calendar
- [ ] Changed year Selector in Year Container as per Material Spec.

Closes mui#3603
Closes mui#3740
Closes mui#1489
Closes callemall/material-ui#3786
tintin1343 added a commit to tintin1343/material-ui that referenced this issue Apr 21, 2016
@tintin1343
[Datepicker] Redesign as per material spec
9d4a407 
Redesign the current Datepicker as per material design spec.
This PR deals with the following:
- [ ] Fixes left pane length
- [ ] Fixes Font weight of left pane date
- [ ] Action buttons are part of calender
- [ ] Action buttons in the year container
- [ ] Vertical Spacing in calendar Month reduced
- [ ] Aligned left and right arrows with days of week
- [ ] Flex design in calender toolbar
- [ ] Incorporated flex design for the overall calender and datepicker
- [ ] Fix both dialog and inline calendar
- [ ] Changed year Selector in Year Container as per Material Spec.

Closes mui#3603
Closes mui#3740
Closes mui#1489
Closes callemall/material-ui#3786
tintin1343 added a commit to tintin1343/material-ui that referenced this issue Apr 26, 2016
@tintin1343
[Datepicker] Redesign as per material spec
c4fbf5d 
Redesign the current Datepicker as per material design spec.
This PR deals with the following:
- [ ] Fixes left pane length
- [ ] Fixes Font weight of left pane date
- [ ] Action buttons are part of calender
- [ ] Action buttons in the year container
- [ ] Vertical Spacing in calendar Month reduced
- [ ] Aligned left and right arrows with days of week
- [ ] Flex design in calender toolbar
- [ ] Incorporated flex design for the overall calender and datepicker
- [ ] Fix both dialog and inline calendar
- [ ] Changed year Selector in Year Container as per Material Spec.

Closes mui#3603
Closes mui#3740
Closes mui#1489
Closes callemall/material-ui#3786
tintin1343 added a commit to tintin1343/material-ui that referenced this issue May 3, 2016
@tintin1343
[Datepicker] Redesign as per material spec
5eca457 
Redesign the current Datepicker as per material design spec.
This PR deals with the following:
- [ ] Fixes left pane length
- [ ] Fixes Font weight of left pane date
- [ ] Action buttons are part of calender
- [ ] Action buttons in the year container
- [ ] Vertical Spacing in calendar Month reduced
- [ ] Aligned left and right arrows with days of week
- [ ] Flex design in calender toolbar
- [ ] Incorporated flex design for the overall calender and datepicker
- [ ] Fix both dialog and inline calendar
- [ ] Changed year Selector in Year Container as per Material Spec.

Closes mui#3603
Closes mui#3740
Closes mui#1489
Closes callemall/material-ui#3786
und3fined pushed a commit to und3fined/material-ui that referenced this issue May 17, 2016
@tintin1343
[Datepicker] Redesign as per material spec
eea1d6f 
Redesign the current Datepicker as per material design spec.
This PR deals with the following:
- [ ] Fixes left pane length
- [ ] Fixes Font weight of left pane date
- [ ] Action buttons are part of calender
- [ ] Action buttons in the year container
- [ ] Vertical Spacing in calendar Month reduced
- [ ] Aligned left and right arrows with days of week
- [ ] Flex design in calender toolbar
- [ ] Incorporated flex design for the overall calender and datepicker
- [ ] Fix both dialog and inline calendar
- [ ] Changed year Selector in Year Container as per Material Spec.

Closes mui#3603
Closes mui#3740
Closes mui#1489
Closes callemall/material-ui#3786
@zannager zannager added component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! browser: Safari labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser: Safari component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Datepicker] Redesign datepicker as per material spec tintin1343/material-ui
6 participants
@Aaron2Ti @treo @Dolmio @mdolinin @alitaheri @zannager