Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon-free #771

Closed
grahamperrin opened this issue Aug 28, 2017 · 13 comments
Closed

icon-free #771

grahamperrin opened this issue Aug 28, 2017 · 13 comments

Comments

@grahamperrin
Copy link

grahamperrin commented Aug 28, 2017

I don't need a circle, a fingerprint or any other icon. The name alone suffices.

Please allow users to have containers without icons.

┆Issue is synchronized with this Jira Task

@jonathanKingston
Copy link
Contributor

I disagree, I don't think we would do this either personally. Will leave open for people to vote on though.

@grahamperrin
Copy link
Author

To clarify: a user preference, not a default.

@jonathanKingston
Copy link
Contributor

User prefs are overused and require maintenance I disagree with using them for every tiny feature.

@grahamperrin
Copy link
Author

grahamperrin commented Aug 29, 2017

Icons are overused … etc. ;-)


If there'll be no user preference, then will WebExtensions APIs allow someone to develop an extension to suppress things such as colours, icons and over/underlines?

@jonathanKingston
Copy link
Contributor

WebExtensions APIs allow someone to develop an extension to suppress things such as colours, icons and over/underlines?

Possibly, perhaps less likely than a pref though. Again leaving this open for voters.

@jplatte
Copy link

jplatte commented Aug 29, 2017

As somebody who has only one container out of six that doesn't have a circle "icon", I don't particularily care whether I can disable them fully or not. But tbh I don't really see the point in having them in the first place. I always identify the container a tab is in by its color in the tab bar, and never pay attention to the container text + icon in the address bar.

@MichaelTunnell
Copy link

My two cents: I don't really care whether the icon is there or not because it takes up very little space and since it is in the far right side of the address bar I usually barely even notice it.

I would rather color options be HEX based so I can choose specific colors. I think that would be better for identification as I only use the tabs like @jplatte described to identify which one it is and I have multiple containers that would be a shade of blue so because I can't do different shades I have different colors that throw me off on occasion.

@grahamperrin
Copy link
Author

… color …

Please join the discussion at Let users set custom colors · Issue #391 · mozilla/testpilot-containers – thank you.

@grahamperrin
Copy link
Author

An example.

After adding (to a clean profile) some of the extensions that I use often, plus one more container-related extension that I found today:

2017-09-10 08 07 14

– the URL is invisible and the reload button is pushed partly beyond the boundary of the field.

After moving a couple of items from the toolbar, to the menu:

2017-09-10 08 09 25 how do i install - activate - run container tabs in firefox firefox support forum mozilla support - mozilla firefox

After moving the search field from the toolbar, to the menu:

2017-09-10 08 12 23 how do i install - activate - run container tabs in firefox firefox support forum mozilla support - mozilla firefox

– still no sight of the tail of the URL.

There we have four add-ons that can not function without taking space from the location field, and Mozilla's is the greatest hog; not a good precedent.

Allowing the user to not show the icon in the location field will make the extension less troublesome in cases such as this.

@grahamperrin
Copy link
Author

2017-10-03 16 49 44

… top right, ah, that's better :-)

Just a little wasted space where previously there was an icon …

Side note

After editing containers.js I found it necessary to quit Firefox for the edition to become effective. (I could have experimented with a less disruptive workaround, but a quit was timely for other reasons.)

From #772 (comment) (2017-08-29) under inconsitencies of colour and name · Issue #772 · mozilla/multi-account-containers:

… require a platform fix.

For Firefox 56.x (affected) I'll seek or raise something in Bugzilla@Mozilla. Or @jonathanKingston do you have a link handy? TIA.

@aaguptaayush
Copy link

where did i add css file in the project

@grahamperrin
Copy link
Author

#771 (comment)

… an extension to suppress things such as colours, icons and over/underlines?

Containers Helper makes it easy to stop the colour variations, with one exception:

@dannycolin
Copy link
Collaborator

This is a design choice from Firefox and there isn't a lot we can do on our side especially for the address bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants