Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letters/symbols/emoji as icons #984

Closed
Madis0 opened this issue Nov 18, 2017 · 9 comments
Closed

Letters/symbols/emoji as icons #984

Madis0 opened this issue Nov 18, 2017 · 9 comments
Labels
Needs: Mozilla Central Needs changes in Mozilla-Central 👍 Feature Request Feature requests users would like to see in this addon

Comments

@Madis0
Copy link

Madis0 commented Nov 18, 2017

In my opinion, the available icons and colors are very limited. The colors are being considered in #391, but the problem with icons is much harder to solve:

  • Ask for more icons - takes time to do and the result may still be too few icons to satisfy users
  • Let users choose an image file - a hard and messy option, would make compatible extensions complex too

So I was thinking - why not just use characters? There are many advantages:

  • Could be as simple as F for Facebook and G for Google
  • Could use emojis to create thousands of color-character combinations (or show the platform-specific SVG and extract it's color)
  • Could just use a period, underscore, space etc. to keep it minimalistic and solve icon-free #771
  • Could even remove the built-in icons and simply suggest some well-visible emojis to replace them
  • Advanced users might not even need titles to know which icon represents which Container, especially Chinese 😁

What do you think?

@yashha
Copy link

yashha commented Nov 19, 2017

Maybe add brand icons like fb and twitter, I have each in a different container
https://github.com/simple-icons/simple-icons

@grahamperrin
Copy link

I manually edited my containers.json file,

{"version":2,"lastUserContextId":31,"identities":[{"userContextId":5,"public":false,"icon":"","color":"","name":"userContextIdInternal.thumbnail","accessKey":""},{"userContextId":19,"public":true,"icon":"","color":"","name":"📱"},{"userContextId":31,"public":true,"icon":"","color":"","name":"🍋"}]}

@jonathanKingston
Copy link
Contributor

I manually edited my containers.json file,

This is a bad idea, the APIs from memory don't handle this well.

@somoso
Copy link

somoso commented Dec 27, 2017

What about using FontAwesome icons, as well as similar font icon packs for the icons?

@grahamperrin
Copy link

… a bad idea, …

Yeah, sorry. I forgot to add that I restart Firefox after edition, and so on …

@groovecoder groovecoder added Needs: Mozilla Central Needs changes in Mozilla-Central 👍 Feature Request Feature requests users would like to see in this addon labels Jan 9, 2018
@groovecoder
Copy link
Member

This would need a platform-level patch; would need to file a bug in bugzilla.

@Madis0
Copy link
Author

Madis0 commented Apr 14, 2018

Forgot to make a Bugzilla bug, but now here it is!

@Paarmita
Copy link

Paarmita commented Sep 21, 2018

@Madis0 @groovecoder @jonathanKingston @yashha I want to work on this issue. Can I add these mentioned icons or some more review is needed?

@Madis0
Copy link
Author

Madis0 commented Sep 21, 2018

@Paarmita I suggested characters instead of specific icons, you may have wanted to tag someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Mozilla Central Needs changes in Mozilla-Central 👍 Feature Request Feature requests users would like to see in this addon
Projects
None yet
Development

No branches or pull requests

7 participants