Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removal of icons #13

Closed
grahamperrin opened this issue Mar 19, 2021 · 3 comments
Closed

Allow removal of icons #13

grahamperrin opened this issue Mar 19, 2021 · 3 comments
Labels
cantfix Affected by an issue out of our control

Comments

@grahamperrin
Copy link

grahamperrin commented Mar 19, 2021

For use cases such as mine, most icons are a waste of space:

image

  • no sense in forcing me to choose an icon for gjp4, and so on.

I want to remove all icons.

Other users might prefer to remove just some icons.

Realistically, it might be difficult (or impossible) to 'close' the space formerly occupied by an icon – see for example mozilla/multi-account-containers#771 (comment) – so I'll be happy with simple removal of icons.

(The dead space will be slightly wasteful, but not troublesome.)

@charles-m-knox
Copy link
Owner

I understand where you're coming from on this. I think the containers API actually requires an icon and color to be set, or else it refuses to create a container entirely. I have to confirm this, but if my suspicion is correct, then it's 100% impossible for me to do anything about it.

However, I could add a user preference to hide/show the icons in the Containers Helper addon popup window, that would be about as close as I could get to this. What do you think @grahamperrin?

@charles-m-knox charles-m-knox added enhancement New feature or request question Further information is requested labels Mar 19, 2021
@grahamperrin
Copy link
Author

Thanks,

… a user preference to hide/show the icons in the Containers Helper addon popup window, …

In that (rarely seen) context, icons don't bother me.

The near-omnipresent address bar context is where I'd like to be without icons.

In the absence of an API, this is probably cantfix.

Certainly, when I disposed of icons, it required manual edition of containers.js

@charles-m-knox
Copy link
Owner

Gotcha. I agree with your assessment and will tag as cantfix and close.

@charles-m-knox charles-m-knox added cantfix Affected by an issue out of our control and removed enhancement New feature or request question Further information is requested labels Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cantfix Affected by an issue out of our control
Projects
None yet
Development

No branches or pull requests

2 participants