Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag current version for NHR if available #22894

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff commented Nov 26, 2024

Fixes: mozilla/addons#1988

Description

Tighten the definition of a report that is individually reviewed, and align how we flag for needs human review with that.

Context

There are a bunch of issues logged (mainly unlisted related) that I duped to mozilla/addons#15179 and this tries to address them all - but mainly by avoiding cases where we were pushing unlisted only add-ons through cinder in the first place.

Appeals on unlisted are covered by mozilla/addons#15182 and this doesn't try to address that issue - only not regress the listed version case.

Testing

  • enable all DSA/abuse related waffle switches
  • report an unlisted only add-on for abuse, without any version of it installed in Firefox;
  • see no job in Cinder in any of the queues. (and nothing in the logs indicating an exception was raised)
  • report an add-on that has at least one approved or awaiting_review versions locally, without any version of it installed in Firefox, for policy violation in the add-on;
  • see the add-on in the manual review queue in reviewer tools, with the current version (the most recent approved version; or the awaiting review version if none are approved) flagged for human review.
  • reject that version
  • appeal the rejection (email with the link will be in django email fakemail)
  • see the add-on in the manual review queue in reviewer tools, with the most recent listed version flagged for human review.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

Copy link

sentry-io bot commented Nov 26, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/olympia/abuse/cinder.py

Function Unhandled Issue
flag_for_human_review AttributeError: 'NoneType' object has no attribute 'id' olympia.abuse.tasks.report_to...
Event Count: 6
flag_for_human_review AttributeError: 'NoneType' object has no attribute 'id' olympia.abuse.tasks.handle_escalate...
Event Count: 4
flag_for_human_review AttributeError: 'NoneType' object has no attribute 'id' olympia.abuse.tasks.appeal_to...
Event Count: 3

Did you find this useful? React with a 👍 or 👎

@eviljeff eviljeff marked this pull request as ready for review November 27, 2024 10:53
@eviljeff eviljeff requested review from a team and diox and removed request for a team November 27, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants