Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: unlisted versions that get rejected, disabled or blocked are not flagged for HR when the author sends an appeal #15182

Open
1 task done
ioanarusiczki opened this issue Nov 20, 2024 · 3 comments
Assignees

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Nov 20, 2024

What happened?

Followup for #15114 (comment)

Submit a first version of an unlisted add-on -> for some reason it is not auto-approved
or
submit an unlisted version and let it auto-approve

Version is rejected, disabled or blocked by reviewers on own initiative

An email goes to the author with an appeal url

The author sends an appeal
Unlisted rejected -> does not get HR
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/634282#review-actions

Unlisted disabled -> does not get HR
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/634283#review-actions

Unlisted restricted -> does not get HR
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/634284

What did you expect to happen?

Flagged for HR and available in the Manual Review Queue

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@eviljeff
Copy link
Member

This is about appeals, right? (I'm assuming from the context of the other issues it is, but it's not mentioned in this issue). Can you edit to clarify?

@ioanarusiczki ioanarusiczki changed the title [Bug]: Unlisted versions are not flagged for HR while not approved and then rejected, blocked or disabled [Bug]: Unsigned unlisted versions that get rejected, disabled or blocked are not flagged for HR when the author sends an appeal Nov 20, 2024
@ioanarusiczki
Copy link
Author

Uh, I only forgot the essential part :P

@ioanarusiczki ioanarusiczki changed the title [Bug]: Unsigned unlisted versions that get rejected, disabled or blocked are not flagged for HR when the author sends an appeal [Bug]: unlisted versions that get rejected, disabled or blocked are not flagged for HR when the author sends an appeal Dec 20, 2024
@ioanarusiczki
Copy link
Author

ioanarusiczki commented Dec 20, 2024

This seems to be a general case for unlisted versions : signed or unsigned so I've updated the title.
Tested with some unlisted versions which are approved and then rejected or disabled. If a developer appeal is sent they're not getting flagged for HR.

disabled https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/635103
or rejected https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/635102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants