Make locales extraction script work with and without token #14049
Conversation
|
Please do test locally. It should work from the container, but do note that it will attempt to checkout to |
| # the following variables to the environment: | ||
| # - GITHUB_TOKEN (to the github token of addons-robot, | ||
| # talk to tofumatt or cgrebs) | ||
| # talk to @diox or @muffinresearch) | ||
| # - TRAVIS_REPO_SLUG="mozilla/addons-server" |
There was a problem hiding this comment.
Can't we provide this as a default in the file?
There was a problem hiding this comment.
As TRAVIS_BRANCH this is automatically present in travis
There was a problem hiding this comment.
I'm thinking for local use so we don't have to define extra variables to make it run.
There was a problem hiding this comment.
Yeah I'll make sure no variables are needed for manual usage
| # the following variables to the environment: | ||
| # - GITHUB_TOKEN (to the github token of addons-robot, | ||
| # talk to tofumatt or cgrebs) | ||
| # talk to @diox or @muffinresearch) | ||
| # - TRAVIS_REPO_SLUG="mozilla/addons-server" | ||
| # - TRAVIS_BRANCH="master" |
There was a problem hiding this comment.
This doesn't appear to be used at all (despite the erroring if it's not set).
There was a problem hiding this comment.
This is purely if used in travis to make sure it's not running against branches other than master
| # the following variables to the environment: | ||
| # - GITHUB_TOKEN (to the github token of addons-robot, | ||
| # talk to tofumatt or cgrebs) | ||
| # talk to @diox or @muffinresearch) | ||
| # - TRAVIS_REPO_SLUG="mozilla/addons-server" | ||
| # - TRAVIS_BRANCH="master" | ||
|
|
There was a problem hiding this comment.
In init_environment it does git checkout master which depends on you having an up-to-date local master. Can we just git checkout upstream/master instead? (Even better if we can always checkout from the repo in TRAVIS_REPO_SLUG)
There was a problem hiding this comment.
mmm in the case of travis, upstream doesn't exist as the remote... I'm going to try to steal some logic from https://github.com/mozilla/addons-frontend/blob/master/bin/run-l10n-extraction for this, pulling from the remote directly.
|
|
||
| if [ "GITHUB_TOKEN" = "" ] | ||
| then | ||
| echo "No Github token provided, you'll have to push the branch and create the pull request yourself." |
There was a problem hiding this comment.
I understand why we can't create the pull request without the github API access but we could still push the branch like https://github.com/mozilla/addons-frontend/pull/9375/files#diff-cae1c8c05fe95719db14844a8f236ab1R76
|
Anything that can be done to have mozilla/addons-frontend#9375 and this work in the same way would be a big improvement - right now the two scripts seem to make a lot of assumptions about git checkouts and branches and it's hard to remember the differences. |
It was! which file was this ? Are you sure your |
Forgot to do It completed and then said: -this is being run in the container so does it have all the relevant git details? |
|
Ah. Ok, so I should probably not even do the |
|
Going to rework this to use the same logic we use on the frontend. |
Helps while we're waiting to have fully automated l10n extraction (mozilla/addons#5872)