Add script to do the l10n extraction #9375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviljeff
approved these changes
Apr 23, 2020
| # Ensure the branch to extract the locales is clean. | ||
| if [[ $(git branch --list "$branch") ]]; then | ||
| info "Deleting branch '$branch' because it already exists" | ||
| git branch -D "$branch" |
There was a problem hiding this comment.
should we delete the remote branch too?
There was a problem hiding this comment.
No, because we need it to open the pull request. That being said, we might want to force push the remote branches in case we didn't delete it previously (github should automatically delete a git branch when the corresponding PR is merged).
bobsilverberg
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#13733
The script handles both 'amo' and 'disco' apps. It takes care of ensuring the
masterbranch is up-to-date before creating a specific branch for the extraction and it detects no changes. The push hero should only run the script once and it will create between 0 and 2 branches on GitHub. The script gives the links to these branches (if any) to open the pull requests.