-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate l10n extract/merge #5872
Comments
Just for the sake of documenting my progress, here are two temporary experiments that progress on automating l10n extraction:
|
With #6020 at least product-details updating won't be needed anymore. |
This comment has been minimized.
This comment has been minimized.
Still needed. |
This comment has been minimized.
This comment has been minimized.
Note: we might want to consider running just the extract (generating the |
I am even more in favor of implementing the proposal here after looking at this. But here is a potential solution for the current manual step of extracting and merging locales using a git pre-commit hook. Screen.Recording.2024-01-10.at.10.00.48.mov |
Adding this here as a WIP of how this could be solved in a scalable way that doesn't deviate too much from the current architecture. We can utilize a github action to handle extracting and merging locales in a fully automated pipeline that can be shared between multiple repositories enabling this feature for all Addons repositories that do locale extraction. Requirements:
This action could be stored in the addons repo and shared with other repositories so long as they are owned by the same org. This is the happy path, but if it is overly complex, or not feasible from a security standpoint, we can always just copy the code and if it needs updating, open PRs in the repos 🤷 anything is possible. The scripts for extracting and merging could be separate or could be just one script that should be executed on each repo. It doesn't seem possible to completely encapsulate the logic for extracting as different repos have different implementations to work with. But if there is an expected script the repo can just add their logic there and the action will do the rest. |
Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-165 |
Acceptance criteria:
Notes:
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: