Two tiny tweaks for Sentry #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
reviewed
Nov 21, 2018
Cargo.toml
Outdated
| @@ -7,6 +7,10 @@ authors = [ | |||
| "Phil Jenvey <[email protected]>", | |||
| ] | |||
|
|
|||
| [profile.release] | |||
| # Enables line numbers in Sentry | |||
| debug = true | |||
There was a problem hiding this comment.
Took me a while to track this down, we came across it for autopush-rs. There's also a not well documented debug value of either 1 (or 2, but true is the equivalent of 2). This value's passed along to rustc -C debuginfo:
-C debuginfo=val -- debug info emission level, 0 = no debug info, 1 = line tables only, 2 = full debug info with variable and type information
debug = 1 sounds ideal for release builds, just producing the line tables
There's been some reports of slowdowns with full release = 2 which may or may not be fixed:
debug = 1 should at the very least reduce the binary size
philbooth
force-pushed
the
pb/sentry-fixes
branch
from
9d99c01 to
06f9f38
Compare
pjenvey
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90.
These are both things I had to fix recently in fxa-email-service, I presume we want to do the same here.
In b2935f5, I stop capturing every error in Sentry because it's too noisy. Currently the only 500 errors we return are from the db error module, so I moved the capture into there.
In 9d99c01, I include debug symbols in the release builds so that Sentry can include line numbers in stack traces.
@bbangert @pjenvey r?