Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include debuginfo in release builds #77

Closed
bbangert opened this issue Sep 18, 2018 · 3 comments · Fixed by #215 or #231
Closed

Include debuginfo in release builds #77

bbangert opened this issue Sep 18, 2018 · 3 comments · Fixed by #215 or #231
Assignees
Labels
1 Estimate - Trivial enhancement New feature or request p1 ready

Comments

@bbangert
Copy link
Member

We can include debuginfo in our release builds for minimal performance hit, but more meaningful errors.

@bbangert bbangert added enhancement New feature or request p2 ready labels Sep 18, 2018
@bbangert
Copy link
Member Author

rust-lang/rust#49227 has some help on this

@pjenvey
Copy link
Member

pjenvey commented Nov 21, 2018

Copying over my explanation from mozilla-services/syncstorage-rs#91 for reference here:

Took me a while to track this down, we came across it for autopush-rs. There's also a not well documented debug value of either 1 (or 2, but true is the equivalent of 2). This value's passed along to rustc -C debuginfo:

    -C            debuginfo=val -- debug info emission level, 0 = no debug info, 1 = line tables only, 2 = full debug info with variable and type information

debug = 1 sounds ideal for release builds, just producing the line tables

There's been some reports of slowdowns with full release = 2 which may or may not be fixed:

rust-lang/rust#49227

debug = 1 should at the very least reduce the binary size

@pjenvey
Copy link
Member

pjenvey commented Nov 21, 2018

Some additional info here: BurntSushi/ripgrep#413

@pjenvey pjenvey added p1 and removed p2 labels Aug 6, 2020
@tublitzed tublitzed added the 1 Estimate - Trivial label Aug 10, 2020
AzureMarker added a commit that referenced this issue Aug 10, 2020
This will enhance error backtraces in Sentry.

Closes #77
This was referenced Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Estimate - Trivial enhancement New feature or request p1 ready
Projects
None yet
4 participants