Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send 4xx errors to Sentry #90

Closed
philbooth opened this issue Nov 21, 2018 · 0 comments · Fixed by #91
Closed

Don't send 4xx errors to Sentry #90

philbooth opened this issue Nov 21, 2018 · 0 comments · Fixed by #91

Comments

@philbooth
Copy link
Contributor

This just bit us in fxa-email-service and the same mistake I made there, I made here:

https://github.com/mozilla-services/syncstorage-rs/blob/master/src/error.rs#L136

We should only send 500 errors to Sentry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Two tiny tweaks for Sentry mozilla-services/syncstorage-rs
1 participant
@philbooth