feat: emit internal bb8 Pool errors to logs/sentry #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
approved these changes
Aug 19, 2020
| extra: HashMap::new(), | ||
| } | ||
| // `uri.path` causes too much cardinality for influx but keep it in | ||
| // extra for sentry |
There was a problem hiding this comment.
Kinda wonder if we should add a comment to the Tags struct to note that extra is ONLY used by sentry. That or change it to be something like sentry_tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #786
Closes #785
Closes #764
Closes #787
Description
Describe these changes.
Testing
How should reviewers test?
Issue(s)
Closes link.