Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit bb8 Pool errors to logs #786

Closed
pjenvey opened this issue Aug 17, 2020 · 0 comments · Fixed by #792
Closed

Emit bb8 Pool errors to logs #786

pjenvey opened this issue Aug 17, 2020 · 0 comments · Fixed by #792
Assignees
@pjenvey
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.

Comments

@pjenvey
Copy link
Member

pjenvey commented Aug 17, 2020

r2d2 by default logs internal "Pool" errors whereas bb8 does not.

So let's setup an ErrorSink that logs them to error!.
@pjenvey pjenvey added the 1 Estimate - xs - This is a trivial change with clearly defined parameters. label Aug 17, 2020
@pjenvey pjenvey self-assigned this Aug 17, 2020
pjenvey added a commit that referenced this issue Aug 18, 2020
@pjenvey
feat: emit internal bb8 Pool errors to logs/sentry
ec25bc4 
- add a keepalive setting
- fix: don't urldecode bso_ids from JSON
- pass the user-agent to sentry as an extra

Closes #786
Closes #785
Closes #764
Closes #787
@pjenvey pjenvey mentioned this issue Aug 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: emit internal bb8 Pool errors to logs/sentry mozilla-services/syncstorage-rs
1 participant
@pjenvey