You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow up to #744 (sorry I missed this before it was merged): we don't want to urldecode bso_ids pulled from JSON payloads, as there's no escaping done there so they should come in unmodified.
We only want to urldecode values received from url path elements.
Another thought: I don't think we need the extra is_ascii check (and the associated InvalidSubmission) -- because all 3 values we pull from the path (bso_id, collection, and uid) do their own validation. The first 2 via a REGEX and uid via u64::from_str.
To further enforce validation, if anything, we could also:
Make sure these results are always validated. Forcing all callers through extrude ensures so. We mistakenly left BsoParam::bsoparam_from_path as a pub function. If mistakenly called instead of extrude the caller could get an unvalidated BsoParam.
u64::from does recognize a leading '+', any source of funny business here with the auth token's contents (probably not)?
The text was updated successfully, but these errors were encountered:
- add a keepalive setting
- fix: don't urldecode bso_ids from JSON
- pass the user-agent to sentry as an extra
Closes#786Closes#785Closes#764Closes#787
Follow up to #744 (sorry I missed this before it was merged): we don't want to urldecode
bso_id
s pulled from JSON payloads, as there's no escaping done there so they should come in unmodified.We only want to urldecode values received from url path elements.
Another thought: I don't think we need the extra
is_ascii
check (and the associatedInvalidSubmission
) -- because all 3 values we pull from the path (bso_id
,collection
, anduid
) do their own validation. The first 2 via a REGEX and uid viau64::from_str
.To further enforce validation, if anything, we could also:
extrude
ensures so. We mistakenly leftBsoParam::bsoparam_from_path
as a pub function. If mistakenly called instead ofextrude
the caller could get an unvalidatedBsoParam
.The text was updated successfully, but these errors were encountered: