This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: send raven calls to event loop #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deadlocks due to raven reporting can occur when exceptions are logged during GC, as twisted may do. As such, the raven call should be sent to the event loop so that twisted's __del__ call can return uninterrupted. Closes #387
|
r+ pending travis. And TIL about reactor.callFromThread() |
bbangert
added a commit
that referenced
this pull request
Mar 4, 2016
fix: send raven calls to event loop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deadlocks due to raven reporting can occur when exceptions
are logged during GC, as twisted may do. As such, the raven
call should be sent to the event loop so that twisted's
del call can return uninterrupted.
Closes #387
@jrconlin r?