fix: send raven calls to event loop

autopush/logging.py

@@ -17,6 +17,7 @@
 import raven
 from eliot import (add_destination, fields,
                    Logger, MessageType)
+from twisted.internet import reactor
 from twisted.python.log import textFromEventDict, startLoggingWithObserver
 
 HOSTNAME = socket.getfqdn()
@@ -41,8 +42,11 @@ def __init__(self):
     def raven_log(self, event):
         """Log out twisted exception failures to Raven"""
         f = event['failure']
-        self.raven_client.captureException(
-            (f.type, f.value, f.getTracebackObject()))
+        # Throw back to event loop
+        reactor.callFromThread(
+            self.raven_client.captureException,
+            (f.type, f.value, f.getTracebackObject())
+        )
 
     def __call__(self, msg):
         """Called to log out messages"""

autopush/tests/test_logging.py

@@ -5,6 +5,8 @@
 
 from mock import Mock, patch
 from nose.tools import eq_, ok_
+from twisted.internet import reactor
+from twisted.internet.defer import Deferred
 from twisted.python import log, failure
 
 from autopush.logging import setup_logging
@@ -28,8 +30,17 @@ def test_sentry_logging(self):
 
         log.err(failure.Failure(Exception("eek")))
         self.flushLoggedErrors()
-        eq_(len(self.mock_client.mock_calls), 1)
+        d = Deferred()
+
+        def check():
+            if len(self.mock_client.mock_calls):
+                eq_(len(self.mock_client.mock_calls), 1)
+                d.callback(True)
+            else:  # pragma: nocover
+                reactor.callLater(0, check)
         del os.environ["SENTRY_DSN"]
+        reactor.callLater(0, check)
+        return d
 
 
 class EliotLogTestCase(twisted.trial.unittest.TestCase):