Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Send raven call to event loop #387

Closed
bbangert opened this issue Mar 4, 2016 · 0 comments
Closed

Send raven call to event loop #387

bbangert opened this issue Mar 4, 2016 · 0 comments
Assignees
@bbangert
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Member

bbangert commented Mar 4, 2016

raven should not run during logging exceptions as twisted may trigger those during garbage collection. Instead the call should be scheduled with callFromThread.
@bbangert bbangert self-assigned this Mar 4, 2016
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Mar 4, 2016
bbangert added a commit that referenced this issue Mar 4, 2016
@bbangert
fix: send raven calls to event loop
d35a78d 
Deadlocks due to raven reporting can occur when exceptions
are logged during GC, as twisted may do. As such, the raven
call should be sent to the event loop so that twisted's
__del__ call can return uninterrupted.

Closes #387
@bbangert bbangert mentioned this issue Mar 4, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
None yet
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
1 participant
@bbangert