This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: Add tags back to metrics #1401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per ops request, this switches metrics to using markus. This also changes the DatadogMetrics library to TaggedMetrics, and becomes the default metrics library if the config value `statsd_host` is set. Closes #1400
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
- Coverage 99.74% 99.62% -0.12%
==========================================
Files 64 65 +1
Lines 10476 10467 -9
==========================================
- Hits 10449 10428 -21
- Misses 27 39 +12
Continue to review full report at Codecov.
|
AzureMarker
reviewed
Jun 23, 2020
AzureMarker
reviewed
Jun 23, 2020
AzureMarker
previously approved these changes
Jun 23, 2020
restore cert test
AzureMarker
previously approved these changes
Jun 23, 2020
AzureMarker
approved these changes
Jun 26, 2020
|
Closing in favor of #1406 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: Add tags back to metrics.
per ops request, this switches metrics to using markus. This also
changes the DatadogMetrics library to TaggedMetrics, and becomes
the default metrics library if the config value
statsd_hostis set.Testing
Unit tests provided.
Issue(s)
Closes #1400