This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: Add tags back to metrics. #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this package does not use the officially sanctioned "markus" metrics package, it does use the same Datadog library. Closes #1400
pjenvey
previously approved these changes
Jun 26, 2020
pjenvey
approved these changes
Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While this package does not use the officially sanctioned "markus"
metrics package, it does use the same Datadog library.
Reviewer Note: this replaces #1401, which does a lot more (replaces metrics libraries with
markus, changes base tag handling, etc.) This PR carries less risk for a service that's being rewritten anyway.Testing
Unit tests included.
Issue(s)
Closes #1400