This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: fixup metrics + tags #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
force-pushed
the
feat/1400b
branch
2 times, most recently
from
ef737f0 to
6a4b5ea
Compare
remove datadog's ThreadStats (as it only speaks datadog's http protocol) w/ markus backed by the plain statsd compatible Datadog backend upgrade datadog to avoid its own telemetry metrics producing garbage tags Co-authored-by: JR Conlin <[email protected]> Closes #1400
jrconlin
approved these changes
Jun 27, 2020
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove datadog's ThreadStats (as it only speaks datadog's http protocol)
w/ markus backed by the plain statsd compatible Datadog backend
upgrade datadog to avoid its own telemetry metrics producing garbage
tags
Note:
This is simplified from #1401 and has a couple other fixes:
['foo:bar', 'baz:quux'], and the PR had a few straggler uses of the old style anyway, so kept what we havetags=kwarg it expectsTesting
Running against a local statsd collector produces expected metrics + tags
Issue(s)
Closes #1400