Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

refactor tests #871

Closed
pjenvey opened this issue Apr 13, 2017 · 0 comments · Fixed by #907
Closed

refactor tests #871

pjenvey opened this issue Apr 13, 2017 · 0 comments · Fixed by #907
Assignees
@pjenvey
Labels
enhancement
Milestone
2017Q2-2.2 Four c...

Comments

@pjenvey
Copy link
Member

pjenvey commented Apr 13, 2017

Our tests could be refined, some improvements along the lines of:

  • inlineCallbacks everywhere (like test_integration)
  • some higher level abstractions could remove a lot of mocks

Cyclone's master branch actually a test client along those lines, we could possibly utilize it (though it's a bit odd in it returns handlers from the request methods.. I suppose we could tweak it)

https://github.com/fiorix/cyclone/blob/master/cyclone/tests/test_testing.py
https://github.com/fiorix/cyclone/blob/master/cyclone/testing/client.py
@pjenvey pjenvey added the ready label Apr 19, 2017
pjenvey added a commit that referenced this issue May 18, 2017
@pjenvey
refactor: bring in cyclone trunk's testing client
47403e5 
(from https://github.com/fiorix/cyclone/blob/c1f830e/cyclone/testing/client.py)

refactor test_endpoint around it & inlineCallbacks

issue #871
pjenvey added a commit that referenced this issue May 18, 2017
@pjenvey
refactor: bring in cyclone trunk's testing client
7b74320 
(from https://github.com/fiorix/cyclone/blob/c1f830e/cyclone/testing/client.py)

refactor test_endpoint around it & inlineCallbacks

issue #871
pjenvey added a commit that referenced this issue May 18, 2017
@pjenvey
refactor: bring in cyclone trunk's testing client
a1b8ae7 
(from:
 https://github.com/fiorix/cyclone/blob/c1f830e/cyclone/testing/client.py
 https://github.com/fiorix/cyclone/blob/9f0dff1/cyclone/tests/test_testing.py
 -> test_client.py)

refactor test_endpoint around it & inlineCallbacks

issue #871
@pjenvey pjenvey mentioned this issue May 18, 2017
Merged
pjenvey added a commit that referenced this issue May 24, 2017
@pjenvey
refactor: convert handler tests to client/inlineCallbacks
e8b6454 
and remove mypy's deprecated fast_parser option

issue #871
pjenvey added a commit that referenced this issue May 24, 2017
@pjenvey
refactor: convert handler tests to client/inlineCallbacks
12bd9b4 
and remove mypy's deprecated fast_parser option

issue #871
pjenvey added a commit that referenced this issue May 24, 2017
@pjenvey
refactor: convert handler tests to client/inlineCallbacks
a4df503 
and remove mypy's deprecated fast_parser option

issue #871
@pjenvey pjenvey mentioned this issue May 24, 2017
Merged
pjenvey added a commit that referenced this issue May 24, 2017
@pjenvey
refactor: convert handler tests to client/inlineCallbacks
bf80e4f 
and remove mypy's deprecated fast_parser option

issue #871
pjenvey added a commit that referenced this issue May 27, 2017
@pjenvey
refactor: convert to inlineCallbacks
71bb8e5 
generalize the waiting code w/ a _wait_for

closes #871
@pjenvey pjenvey mentioned this issue May 27, 2017
Merged
@pjenvey pjenvey self-assigned this May 27, 2017
@pjenvey pjenvey added in progress and removed ready labels May 27, 2017
pjenvey added a commit that referenced this issue Jun 9, 2017
@pjenvey
refactor: convert to inlineCallbacks
0715626 
and cleanup NotificationHandler delete's args/regex

issue #871
@pjenvey pjenvey mentioned this issue Jun 10, 2017
Merged
pjenvey added a commit that referenced this issue Jun 12, 2017
@pjenvey
refactor: convert to inlineCallbacks
39f09d3 
and cleanup NotificationHandler delete's args/regex

issue #871
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
enhancement
Projects
None yet
Milestone
2017Q2-2.2 Four code refactor issues ...
Development

Successfully merging a pull request may close this issue.

refactor: convert to inlineCallbacks mozilla-services/autopush
2 participants
@pjenvey @bbangert