This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
refactor: convert to inlineCallbacks #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
added this to the 2017Q2-2.2 Four code refactor issues completed and obsolete legacy code removed... milestone
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 57 57
Lines 9394 9383 -11
=====================================
- Hits 9394 9383 -11
Continue to review full report at Codecov.
|
jrconlin
approved these changes
Jun 12, 2017
bbangert
reviewed
Jun 12, 2017
autopush/http.py
Outdated
| @@ -153,7 +153,7 @@ class InternalRouterHTTPFactory(BaseHTTPFactory): | |||
|
|
|||
| ap_handlers = ( | |||
| (r"/push/([^\/]+)", RouterHandler), | |||
| (r"/notif/([^\/]+)(/([^\/]+))?", NotificationHandler), | |||
| (r"/notif/([^\/]+)(?:/([^\/]+))?", NotificationHandler), | |||
There was a problem hiding this comment.
We're going to int the last arg, maybe only match on digits?
and cleanup NotificationHandler delete's args/regex issue #871
bbangert
approved these changes
Jun 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and cleanup NotificationHandler delete's args/regex
issue #871