This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
refactor: convert handler tests to client/inlineCallbacks #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
added this to the 2017Q2-2.2 Four code refactor issues completed and obsolete legacy code removed... milestone
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 56 57 +1
Lines 9738 9669 -69
=====================================
- Hits 9738 9669 -69
Continue to review full report at Codecov.
|
bbangert
approved these changes
May 24, 2017
autopush/logging.py
Outdated
| globalLogBeginner.beginLoggingTo( | ||
| [observer], | ||
| redirectStandardIO=redirectStandardIO, | ||
| **kwargs) |
There was a problem hiding this comment.
Do we want to drop the ) when we immediately drop-line after starting, or keep it this way? I'm fine with either way, just want to know which one we should use everywhere.
There was a problem hiding this comment.
we've standardized dropping it lately, I forgot it here
and remove mypy's deprecated fast_parser option issue #871
jrconlin
approved these changes
May 25, 2017
| @@ -92,7 +92,9 @@ def for_handler(cls, handler_cls, *args, **kwargs): | |||
| thrown. | |||
|
|
|||
| """ | |||
| for pattern, handler in cls.ap_handlers: | |||
| if 'handlers' in kwargs: # pragma: nocover | |||
There was a problem hiding this comment.
Not a stopper, but we can't test this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove mypy's deprecated fast_parser option
issue #871